Closed
Bug 1013311
Opened 11 years ago
Closed 11 years ago
Make Editor throwing JS error on page load
Categories
(Webmaker Graveyard :: MakeAPI, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cade, Assigned: cade)
Details
Attachments
(1 file)
It looks like a recent MakeAPI client update added a check to the constructor, which is breaking a hack that the Make Editor was using.
In order to use the admin protected search route, we provided an empty hawk credentials object in the constructor params. To fix this we just need a fake id and key value.
|
Assignee | |
Comment 1•11 years ago
|
||
this change stops the client code from throwing.
Attachment #8425553 -
Flags: review?(jon)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8425553 [details] [review]
https://github.com/mozilla/MakeAPI/pull/219
What, no silly hex values like 0xDEADBEEF ? :)
Attachment #8425553 -
Flags: review?(jon) → review+
|
||
Comment 3•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/MakeAPI
https://github.com/mozilla/MakeAPI/commit/b03424de19588a761d7910ac2aaebf9eaf444efb
bug 1013311 - Fix admin tool
|
|
Assignee | |
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•