1013325 - [roku] add call to init SSL certs for video player

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Screencasting, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: video-cert v0.1

We ship some default videos in "Recent History" and I noticed they were not working. Failing with "Unspecified or invalid track path/url" message.

I realized the videos were from an HTTPS source and discovered we needed to tell the video player about SSL certs to get the HTTPS GET to work.

The patch also updates the default videos to use HTTPS urls and skip the redirect.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

I am blocked on releasing the Roku app for this patch. Let me know if you want me to get a different reviewer.

Comment 2

[Wesley Johnston (:wesj)]

Comment on attachment 8425537 [details] [diff] [review]
video-cert v0.1

Review of attachment 8425537 [details] [diff] [review]:
-----------------------------------------------------------------

Looking at roku example code, I think we might need a bit more (but its a simple change). Maybe you know why they're not needed here though? Feel free to carry the r+ if you make the change.

::: app/json/defaults.json
@@ +13,1 @@
>  	}            

might as well remove this ws.

::: app/source/video.brs
@@ +18,4 @@
>      this.canvas.show()
>  
>      this.player.setMessagePort(this.port)
> +    this.player.setCertificatesFile("common:/certs/ca-bundle.crt")

Every example of this I see also calls player.InitClientCertificates() after setting. Most of them also set a header:

video.Addheader("x-roku-reserved-dev-id","")
video.SetCertificatesFile("pkg:/source/testCA.CRT")
video.InitClientCertificates()

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Wesley Johnston (:wesj) from comment #2)

> Looking at roku example code, I think we might need a bit more (but its a
> simple change). Maybe you know why they're not needed here though? Feel free
> to carry the r+ if you make the change.

> Every example of this I see also calls player.InitClientCertificates() after
> setting. Most of them also set a header:
> 
> video.Addheader("x-roku-reserved-dev-id","")
> video.SetCertificatesFile("pkg:/source/testCA.CRT")
> video.InitClientCertificates()

InitClientCertificates() should only be needed if we use a custom certificate, if I understand things correctly. Using the built-in cert might not need the init. I did test with and without, and SetCertificatesFile was all that was needed to get the videos to work.

The header is only needed if you want to send "Firefox" (the id of the application/channel) to the webserver, which we do not.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://github.com/mozilla/firefox-roku/commit/7bfb510e9d1c5c89767322fa85f07261bd20175b