1013363 - Australis - WebRTC button looks broken in menu panel

Status: RESOLVED INVALID

(Firefox :: Theme, defect)

Description

[Tim Nguyen :ntim]

It currently shows the full sprite, which is quite ugly.

STR :
- Open a page with WebRTC
- Place the WebRTC button in menu panel

Also, let's avoid using the "Restrict WebRTC button to nav-bar" solution.

Comment 1

[Dão Gottwald [:dao]]

(In reply to Tim Nguyen [:ntim] from comment #0)
> - Place the WebRTC button in menu panel

This isn't even possible as far as I can tell. The button isn't supposed to be movable.

Comment 2

[Justin Dolske [:Dolske]]

If it's removable, that would be a bug. It's intended to be an obvious indicator that something is using your camera/mic, and havign that become not-visible would be bad. (Discussion if/how to allow putting it elsewhere would be fodder for a separate bug.)

I can't reproduce this with http://mozilla.github.io/webrtc-landing/gum_test.html. The context menu commands are disabled, and it's not dragable in customize mode.

(Also, we are not longer using the [Australis:P#] system.)

Comment 3

[Tim Nguyen :ntim]

(In reply to Justin Dolske [:Dolske] from comment #2)
> If it's removable, that would be a bug. It's intended to be an obvious
> indicator that something is using your camera/mic, and havign that become
> not-visible would be bad. (Discussion if/how to allow putting it elsewhere
> would be fodder for a separate bug.)
> 
> I can't reproduce this with
> http://mozilla.github.io/webrtc-landing/gum_test.html. The context menu
> commands are disabled, and it's not dragable in customize mode.
> 
> (Also, we are not longer using the [Australis:P#] system.)

Hmm, maybe Classic Theme Restorer is causing it to removable. But it's still a bug that it shows the whole sprite in menu-panel, it means that the placeholder icon in the sprite is no used.

Comment 4

[Dão Gottwald [:dao]]

(In reply to Tim Nguyen [:ntim] from comment #3)
> Hmm, maybe Classic Theme Restorer is causing it to removable.

Then this is Classic Theme Restorer's bug to fix.

> But it's still
> a bug that it shows the whole sprite in menu-panel, it means that the
> placeholder icon in the sprite is no used.

This doesn't really make sense. If something shouldn't be in the panel in the first place, how it should behave in the panel is undefined. Let's not spend time on this.