1013374 - Optimize display timing of translation infobar and icon

Status: RESOLVED INACTIVE

(Firefox :: Translations, defect)

Description

[Mike de Boer [:mikedeboer]]

In bug 1003118 we discovered that an up to 68% decrease in page drawing performance was measured by the tp5o_paint Talos test.
Additionally, we established that showing the translation infobar and the icon in the urlbar notification area is the main reason for this regression.

We need to investigate why this is the case exactly and remedy the cause in this bug.

Comment 1

[Mike de Boer [:mikedeboer]]

Marco, can you add this to the current iteration?

Comment 2

[Marco Mucci [:MarcoM]]

Added to Iteration 32.2

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Hey Mike, some food for thought here after a conversation with Gavin:

- displaying and animating the UI during a timing test is obviously more work done on the main thread, so it's expected that the numbers would be affected by it

- if we just try to move it outside of the measurement of the test we're not really gaining much of real value, specially as we want to display the infobar earlier and not later (bug 997818)

- a useful setup for testing would be one where we would have language detection running during talos, but with the UI disabled, because that would be testing the real work done during pageload for every page

- we will need this setup anyway (lang. detect enabled, UI disabled) because during the trial run we want to have a control group for our data analysis, and in that group we want to measure the language of websites visited without the presence of a translation feature

This is not saying that it isn't a valid bug that infobars are sluggish and needs to be optimized, but it's a not problem particular to the translation infobar. So with the above points I believe it's not worth struggling with this bug at the moment. Maybe a better next step is to add this more fine grained configuration.

Comment 4

[Mike de Boer [:mikedeboer]]

(In reply to :Felipe Gomes from comment #3)
> - a useful setup for testing would be one where we would have language
> detection running during talos, but with the UI disabled, because that would
> be testing the real work done during pageload for every page

I agree, good point. I'll file a new bug and we'll figure out the best way to do that there.

Especially a 'talos switch' to disable the ui should prove to be interesting ;)

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Sounds like we should drop this bug from the current iteration, then?

Comment 6

[Mike de Boer [:mikedeboer]]

(In reply to :Gavin Sharp (email [e-mail]) from comment #5)
> Sounds like we should drop this bug from the current iteration, then?

Aye! Marco, can you remove this bug from the current iteration?

Comment 7

[Marco Mucci [:MarcoM]]

Removed from Iteration 32.2