1013396 - $anchorScroll sometimes fails on competency pages

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[inactivate account for kate]

When clicking sections under the 'jump to' sticky sidebar, sometimes it does not jump to the correct location; clicking it a second time usually fixes this.

Comment 1

[Cassie McDaniel [:cassiemc]]

Reassigning to Aki since Kate is away this week.

Comment 2

[Aki Rose Braun [:akirose]]

I've taken apart and re-assembled this script, still don't know why it's doing what it's doing, but at least at this point I can say what it IS doing.

By clicking on any of the three fixed ToC items on any competency view:

- Click #1 MakeAPI-Client(makeapi.js) sends a request to the Make API; some script somewhere jumps window.scrollTop to… somewhere. The somewhere is predictable based on your window.height, but I haven't really figured out any rhyme or reason for it.

- Click #2 executes the desired $location.hash(id); $anchorScroll() as long as you haven't scrolled away from wherever click #1 landed you.

It does the same thing whether the function to scroll is inside its own directive, or in the controller as a function on scope called with ng-click.

I literally have no idea why this is happening.

Comment 3

[Cassie McDaniel [:cassiemc]]

Aki I've removed this from this sprint. Can we just take this functionality out for now and address it next sprint?

Comment 4

[Aki Rose Braun [:akirose]]

Okay I created Bug #1018281 to remove it, and we'll leave this open to re-add it as soon as we can.

Comment 5

[Brett Gaylor [:brett]]

Kate since we are launching resources to prod this week, can you take a look?

Comment 6

[inactivate account for kate]

Attachment: https://github.com/mozilla/webmaker.org/pull/766

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/7a6b74310d8881d8fa3a630fbaf78ebd7cd05ff2
Bug 1013396 - $anchorScroll sometimes fails on competency pages, remove makeapi that isn't being used.