1013425 - [B2G][Flame][Camera] Preview stuck when taking picture in HDR mode

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Andrew Osmond [:aosmond] (he/him)]

From bug 1007973:

3) Unresponsive / freezing camera when switching HDR ON and taking a picture
This issue involves starting the camera app with the HDR set to off, setting it to ON and then taking a picture. Like the 1st issue the ring will appear, turn green and shrink down, then the screen will quickly flash, then viewfinder will "freeze" indefinately on the still image of the picture just taken. After 4 or 5 seconds the preview thumbnail will appear to the left of the shutter button. You will still be able to access the settings, switch the camera to video, or access the preview thumbnail. Accessing the preview thumbnail will take you to the picture just taken but then returning to the camera via the back arrow in the upper left corner will return you to a black screen with all the camera icons and buttons. If instead you minimize the app and re-enter it or switch to video mode and back everything will operate normally. 
This also reproduces 100%

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: bug1013425.patch

Comment 2

[Jason Smith [:jsmith]]

Should this be nomed for 1.4?

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

(In reply to Jason Smith [:jsmith] from comment #2)
> Should this be nomed for 1.4?

Yes.

Comment 4

[Mike Habicher [:mikeh] (high bugzilla latency)]

Comment on attachment 8425630 [details] [diff] [review]
bug1013425.patch

Review of attachment 8425630 [details] [diff] [review]:
-----------------------------------------------------------------

Ship it!

::: dom/camera/GonkCameraControl.cpp
@@ +423,5 @@
>        break;
> +
> +    case CAMERA_PARAM_SCENEMODE:
> +      // Reset disabling normal pictures in HDR mode in conjunction with setting
> +      // scene mode because some drivers require they be changed together

nit: period at the end please.

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

Attachment: bug1013425.patch, v1.1 [r=mikeh]

Fix nits.

Comment 6

[Andrew Osmond [:aosmond] (he/him)]

try: https://tbpl.mozilla.org/?tree=Try&rev=a8189035c49a

Comment 7

[Andrew Osmond [:aosmond] (he/him)]

Test 8 failure on emulator is unrelated, as are Windows 7 test 3 and Windows 8 bc1.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

FWIW, this file is NPOTB for anything other than B2G, so try to avoid the needless builds/tests on other platforms in the future :)

https://wiki.mozilla.org/Sheriffing/How:To:Recommended_Try_Practices

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/6a7f5df97834

Comment 10

[Mike Habicher [:mikeh] (high bugzilla latency)]

RyanVM: that link to b2g-inbound doesn't look at all correct. :)

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Whoops.
https://hg.mozilla.org/integration/b2g-inbound/rev/066a0768d6dd

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/066a0768d6dd

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Needs a branch patch rebased on top of b2g30_v1_4 for v1.4 uplift.

Comment 14

[Andrew Osmond [:aosmond] (he/him)]

Attachment: bug1013425.patch for Gecko 1.4, v1

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/1d98f47152ef