1013481 - duplicate declaration of dataroot/bin directory in puppet

Status: RESOLVED FIXED

(Data & BI Services Team :: DB: MySQL, task)

Description

[Sheeri Cabral [:sheeri]]

< nagios-phx1> Mon 11:32:27 PDT [1894] puppetdashboard2.db.phx1.mozilla.com:Puppet catalog compilation is CRITICAL: Could not retrieve catalog from remote server: Error 400 on SERVER: Duplicate declaration: File[/var/lib/pgsql/bin] is already declared in file /etc/puppet/modules/postgres/manifests/profile.pp:37: cannot redeclare at /etc/puppet/modules/postgres/manifests/server.pp:175

Comment 1

[Sheeri Cabral [:sheeri]]

I want to upgrade ssl on puppetagain and this problem is preventing me from using yum-wrapper appropriately, so I'm working on this.

Comment 2

[Sheeri Cabral [:sheeri]]

In profile.pp on line 37:

        '/var/lib/pgsql/bin':
            ensure  =>  directory,
            owner   =>  'postgres',
            group   =>  'postgres',
            mode    =>  '0755',
            #require =>  File['/var/lib/pgsql'];
            require => Package["postgresql${postgres::server::pg_version}-server"];


So, in sever.pp we have, starting on line 114:
        $dataroot:
            ensure  => directory,
            owner   => 'postgres',
            group   => 'postgres',
            mode    => '0700',
            require => Package["postgresql${pg_version}-server"];

and then on line 128:
128        $dataroot_bin:
129             ensure  => directory,
130             owner   => 'postgres',
131             group   => 'postgres',
132             mode    => '0700',
133             require => File[$dataroot];

Really, we should not hard-code /var/lib/pgsql in profile.pp.

Comment 3

[Sheeri Cabral [:sheeri]]

server.pp includes postgres::profile, and dataroot comes from params

$dataroot                   = $postgres::params::dataroot,

Comment 4

[Sheeri Cabral [:sheeri]]

Sheeri-Cabral:manifests scabral$ svn commit -m "applying fixes for bug 1013481"
Sending        profile.pp
Sending        server.pp
Transmitting file data ..
Committed revision 87744.

Comment 5

[Sheeri Cabral [:sheeri]]

putting all the dataroot directory and subdirectory declarations in profile.pp, r87753.

Comment 6

[Sheeri Cabral [:sheeri]]

Still working on this, but going to lunch.

Comment 7

[Sheeri Cabral [:sheeri]]

puppetagain1 is fine, but puppetagain2 has 

Error: Failed to apply catalog: Could not find dependency File[/var/lib/pgsql/9.2/data] for Exec[postgres_initdb]

Comment 8

[Sheeri Cabral [:sheeri]]

These errors are no longer occurring on puppetagain2, so this matter is resolved.