1013509 - Geolocation permission prompt will never hide

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Hubert Figuiere [:hub]]

This happen programmatically. On a flame, but likely on other devices.

Completely reset gaia.

|APP=camera make test-perf|

Camera app will start, ask for permission.
Camera app will be quit.


Permission prompt is still there.

Expected:

Permission prompt should be removed, treating the whole thing like operation was cancelled: permission remains unchanged.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: 2014-06-26-12-58-17.png

Lockscreen will be underneath the geolocation prompt.

You can see the lockscreen through the overlay.

Gaia      87a7746568ac5708e828026160c0732ba252300f
Gecko     https://hg.mozilla.org/mozilla-central/rev/c43be7e4ec49
BuildID   20140626040205
Version   33.0a1
ro.build.version.incremental=eng..20140508.024737
ro.build.date=Thu May  8 02:48:06 CST 2014

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Doesn't seem to happen in 1.4

Comment 3

[Duane Dixon [:ddixon]]

B2G Inbound Regression Window

Last Working

Device: Flame Master
Build ID: 20140612002012
Gaia: ba365c8f7feda34e582ce1721cf538f417c92a75
Gecko: db71d2354a77
Version: 33.0a1 (Master)
Firmware Version: v122

First Broken

Device: Flame Master
Build ID: 20140612004232
Gaia: 856395fcb9451f7b36184be9d337d103be647564
Gecko: fbe676419fa5
Version: 33.0a1 (Master)
Firmware Version: v122

Last Working Gaia and First Broken Gecko
Issue DOES NOT occur here. 
Gaia: ba365c8f7feda34e582ce1721cf538f417c92a75
Gecko: fbe676419fa5

Last Working Gecko and First Broken Gaia
Issue DOES occur here. 
Gaia: 856395fcb9451f7b36184be9d337d103be647564
Gecko: db71d2354a77

Gaia Pushlog: 
https://github.com/mozilla-b2g/gaia/compare/ba365c8f7feda34e582ce1721cf538f417c92a75...856395fcb9451f7b36184be9d337d103be647564


Possible causes: 
Bug 1011589 - Follow-up, update gaia_node_modules.revision 

Bug 1020959 - [vertical] search bar is visible when geolocation promp…

Comment 4

[Joshua Mitchell (Inactive)]

Possibly broke by bug 1020959 - Kevin can you take a look?

Comment 5

[Kevin Grandon :kgrandon]

I am looking now - we only changed z-indexing ordering, so if we're really killing the app and permission dialons like we should be, then this shouldn't be a problem.

Can a user get into this situation?

Comment 6

[Kevin Grandon :kgrandon]

Hub - few questions:

1 - Can a user get into this situation?

2 - Should we disable geolocation for test-perf as we do for marionetteJS tests? One example, https://github.com/mozilla-b2g/gaia/blob/master/apps/verticalhome/test/marionette/collection_uninstall_test.js#L41

Comment 7

[Jason Smith [:jsmith]]

(In reply to Kevin Grandon :kgrandon from comment #6)
> Hub - few questions:
> 
> 1 - Can a user get into this situation?

Yes. You just need to hit the home button with a prompt present in an app.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Kevin, it seems you are already working on this.

Comment 9

[Kevin Grandon :kgrandon]

Not yet working on this, but might be able to investigate today. If I get time I will assign it to myself.

Comment 10

[Kevin Grandon :kgrandon]

Aus - do you have time to take a look at this?

Comment 11

[Aus Lacroix [:aus]]

I can have a look at this today. The dialog should be getting dismissed when the application requesting it gets killed. Maybe we weren't doing that before and simply relying on the z-order to do this for us? Either way, I don't think it should be too hard to work around it for this release.

Comment 12

[Aus Lacroix [:aus]]

So, how exactly do I get this to happen as a user?

I've tried with the Camera app and the Geoloc test app which both bring up the permissions dialog. If I dismiss it by hitting the home button, it goes away as expected.

In the test, how do we quit the application exactly? Do we just kill it?

Comment 13

[Joshua Mitchell (Inactive)]

Dixon - you did the regression window here - can you please address comment 12, and elaborate on the exact repro-steps.

Comment 14

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Aus figured it out.  He can kill the app and get into that state.

More details on comment 1: I ran the script on device : 
export MARIONETTE_RUNNER_HOST=marionette-device-host
make test-integration-test APP=camera

And then hit the power button while the overlay was up.

Comment 15

[Joshua Mitchell (Inactive)]

cancelling the need-info

Comment 16

[Aus Lacroix [:aus]]

Attachment: Pull Request - Dismiss Permission Request when Requester is terminated.

Comment 17

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8449036 [details] [review]
Pull Request - Dismiss Permission Request when Requester is terminated.

Good to me if this fixes the problem, could you have a test? Thank you.

Comment 18

[Aus Lacroix [:aus]]

Commit (master): https://github.com/mozilla-b2g/gaia/commit/1ba15ce1ae7254badd25fd276556c1b4f36c0a45

Commit (v2.0): https://github.com/mozilla-b2g/gaia/commit/3b6f00b9b755cdec454e63ae720e74882a6f8ea7

Fixed!

Comment 19

[Hubert Figuiere [:hub]]

(In reply to Kevin Grandon :kgrandon from comment #6)

> 2 - Should we disable geolocation for test-perf as we do for marionetteJS
> tests? One example,
> https://github.com/mozilla-b2g/gaia/blob/master/apps/verticalhome/test/
> marionette/collection_uninstall_test.js#L41

That's a possibility but given that it is fixed now....

Comment 20

[sarsenyev]

Verified the issue is fixed on 2.0 and 2.1
The Geolocation prompt is hidden

"Flame 2.0

Device: Flame 2.0 (319mb)(Kitkat Base)(Shallow Flash)
Build ID: 20141118000207
Gaia: 1ede2666f1e6c1b3fd3b282011caf0cbc59544b0
Gecko: 2bea026d4f86
Version: 32.0 (2.0)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0"

"Flame 2.1 

Device: Flame 2.1 (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141118001204
Gaia: 1b231b87aad384842dfc79614b2a9ca68a4b4ff3
Gecko: 95fbd7635152
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0"