Closed Bug 1013516 Opened 6 years ago Closed 6 years ago

Don't ship unneeded in-content preferences files

Categories

(Firefox :: Preferences, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 32

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

The separate XUL files are during building added into the preferences.xul file and also shipped to omni.ja. This isn't needed and makes the omni.ja only bigger.
Attached patch noFilesShip.patch (obsolete) — Splinter Review
Removed the files from jar.mn and let remove the MPL headers during building. I added comments for easier finding the panes in preferences.xul.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8425687 - Flags: review?(jaws)
(In reply to Richard Marti (:Paenglab) from comment #1)
> remove the MPL headers during building.

Please use the second style listed here: http://www.mozilla.org/MPL/headers/
Comment on attachment 8425687 [details] [diff] [review]
noFilesShip.patch

Review of attachment 8425687 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the headers switched as Dao pointed out.
Attachment #8425687 - Flags: review?(jaws) → review+
Changed the headers.
Attachment #8425687 - Attachment is obsolete: true
Attachment #8425770 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ea2ef5b9ee02
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
Hi, 

as part of Verification Day on #testday, I wanted to verify this bug but I'm at loss on how to do it: is this something that it's visible to users? What steps would you suggest to verify it?

Thanks in advance,
Francesca

ps: I always have this doubt about bugs not directly related to user experience nor clearly visible on the UI and I finally found the courage to ask ;)
Flags: needinfo?(richard.marti)
Hi, thanks for the interest. This bug isn't worth QAing. Basically, if opening the preferences and changing categories still works then we are all good.
Status: RESOLVED → VERIFIED
Whiteboard: [qa-]
Flags: needinfo?(richard.marti)
You need to log in before you can comment on or make changes to this bug.