1013523 - Remove history check in in-content preferences.js

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Richard Marti (:Paenglab)]

For me it looks like the history check isn't needed in in-content preferences.js.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: noHistoryCheck.patch

To be honest I don't know what this is doing but I see no change after removing this code.

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

This was meant to select the right category when undo closing an about:preferences tab. However, that seems currently broken.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8425695 [details] [diff] [review]
noHistoryCheck.patch

Review of attachment 8425695 [details] [diff] [review]:
-----------------------------------------------------------------

Blair, do you know why this is here?

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8425695 [details] [diff] [review]
noHistoryCheck.patch

I didn't see ttaubert's comment until now.

Comment 5

[Richard Marti (:Paenglab)]

Try: https://tbpl.mozilla.org/?tree=Try&rev=48626eeaa612

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Why are we removing this code? We should rather fix it.

Comment 7

[Richard Marti (:Paenglab)]

Bug 1012368 was WONTFIXed to not remembering the last opened pane. This would also apply on reopening a tab.

Jared, what do you think?

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/41ae72b01470

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Richard Marti (:Paenglab) from comment #7)
> Bug 1012368 was WONTFIXed to not remembering the last opened pane. This
> would also apply on reopening a tab.
> 
> Jared, what do you think?

Hypothetically, if this code was only present for the case of restoring a closed tab, should we still keep it? Is that a common enough use case to add it to the matrix of test cases?

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

I don't know. I can see it go either way - there might be people that expect that to work because it's a tab. OTOH maybe people don't even recognize it's a tab and just see it as "the prefs dialog" and don't even expect that to be restorable with undo close.

Comment 11

[Camelia Badau [:cbadau], Desktop QA]

Verified on Windows 7 64bit, Ubutu 13.10 32bit and Mac OSX 10.8.5 and the following mentions should be done: 
 - for Firefox 32 Beta 4 (buildID: ), this bug is fixed: after reopening a tab, the last opened pane is not remembered; the General pane is displayed
                  - the name displayed in Location Bar is about:preferences (without #general, #privacy, etc.)
 - for Nightly 34.0a1 (buildID: ): after reopening a tab, the last opened pane is remembered  
                  - the name displayed in Location Bar is about:preferences#general/privacy/etc

Here is an inconsistency between latest Nightly 34.0a1 and Beta 32.0b4.

Is this intended behaviour? That this bug should be fixed only on Beta 32.0b4 and not fixed in latest Nightly 34.0a1 since the In-content Preferences feature is not shipped yet in Beta?

Comment 12

[Camelia Badau [:cbadau], Desktop QA]

Firefox 32 Beta 4 (buildID: 20140804164216)
latest Nightly 34.0a1 (buildID: 20140806030201)

Comment 13

[Richard Marti (:Paenglab)]

I think this is because Bug 754304, which is Target Milestone: Firefox 33, changes this behavior a bit.