1013594 - [B2G][Video] When selecting a video in the Video App, the video will flicker blue

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Attachment: Locgcat Open C 1.4

Description:
When the user is selecting a video in the video app, it will be selected, but will flicker during the selection process

Prerequisites: Have a memory card with at least 1 video on it

Repro Steps:
1) Update a Open_C to BuildID: 20140513000208
2) Open Video app
3) Tap on select tool in bottom right
4) Select a video

Actual:
The video will be selected but it will flicker in a blue highlight while it is being selected

Expected:
Video is selected as indicated by blue bounding box without flickering

Open C 1.4
1.4 Environmental Variables:
Device: Open_C 1.4
BuildID: 20140516000201
Gaia: 32fca83da31b9a0f9a5a88f96c913a25accdc14b
Gecko: a1e455367fa6
Version: 30.0
Firmware Version: P821A10V1.0.0B06_LOG_DL

Keywords: Highlight, Quick, Brief, Shown

Repro frequency: 95%
See attached: Logcat, Video - http://youtu.be/mt043aI-PWo

Comment 1

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This issue DOES occur on Buri 1.4

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140519000201
Gaia: defd0650fb9d30c6515d50a89e72d8fb74ce7e62
Gecko: d95594048b36
Version: 30.0
Firmware Version: v1.2-device.cfg

Comment 2

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This issue DOES occur on Flame 1.4

1.4 Environmental Variables:
Device: Flame 1.4
BuildID: 20140520000201
Gaia: 17b102ee8d9a724b62285547cc5f1c5d30bfb01c
Gecko: 95be84248033
Version: 30.0
Firmware Version: v10f-3

Comment 3

[Jason Smith [:jsmith]]

Does this occur on 1.3?

Comment 4

[Eric Kramer [:Kramer]]

This issue DOES repro on 1.3 Open_C

Device: Open_C 1.3
BuildID: 20140505052400
Gaia: Unknown Git commit; build date shown here.
Gecko:
Version: 28.0
Firmware Version: FFOS_US_EBAY_P821A10V1.0.0B06_LOG_DL


This issue DOES repro on Buri 1.3 (it is more difficult to reproduce / not instantaneous like the other builds).

Device: Buri 1.3
BuildID: 20140521062818
Gaia: 0ce948e378cab7ed3db20231281dd7ca2eb99779
Gecko: fce835f24818
Version: 28.0
Firmware Version: v1.2-device.cfg

Comment 5

[Joshua Mitchell (Inactive)]

This issue still occurs on Flame KK 2.0 through 3.0

Device: Flame 3.0 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150414072436
Gaia: c8cb0c0ebb8dd1f5c0c9037e38f8e4b237beb77b
Gecko: 388f5861dc7d
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0


Device: Flame 2.2 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150413002502
Gaia: cec00d643f517ffd96cde559cd3bbd43ab85816c
Gecko: 5005522fd68e
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Flame 2.1 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150413001204
Gaia: bbe983b4e8bebfec26b3726b79568a22d667223c
Gecko: a1b2434ad001
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 34.0 (2.1)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


Device: Flame 2.0 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150413000202
Gaia: 84898cadf28b1a1fcd03b726cff658de470282f0
Gecko: 5c45a15eb2b4
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 32.0 (2.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 6

[Peter Bylenga [:PBylenga]]

NI on component owner for assignment, long standing issue.

Comment 7

[No-Jun Park [:njpark]]

ni?ing djf.  It is an old issue since 1.4, which is still happening in all of the builds.  Would there be a chance to resolve this, or is this a gecko issue?

Comment 8

[David Flanagan [:djf]]

When you touch any of the thumbnails in the list of videos, the entire thing highlights blue to show that it is touched.  That is normal. It flickers more on the right-hand side of the screen because the background color shows up better there, maybe?

If you tap more slowly when selecting, then this would probably just seem like a normal highlight and not a bug.

From the video it almost appears as if the flicker gets worse as more videos are selected. If that is actually the case, then maybe we've got an event handler that is taking too long to handle taps, and we can probably do something to fix that in gaia.

No-jun: is this an issue where the flicker gets worse as more videos are selected?  If so, then please ask :russn to investigate it.

If the flicker is the same regardless of the number of selected videos, then please ask UX whether they consider this a bug or a feature.  If UX wants the highlight-on-touch behavior changed, it is probably just a one-line CSS fix.

Comment 9

[Joshua Mitchell (Inactive)]

There is also the addition of it highlighting inconsistently. About 10-20% of the time I tap I do NOT see the blue highlighting, only the blue border being drawn.

Comment 10

[No-Jun Park [:njpark]]

H(In reply to Joshua Mitchell [:Joshua_M] from comment #9)
> There is also the addition of it highlighting inconsistently. About 10-20%
> of the time I tap I do NOT see the blue highlighting, only the blue border
> being drawn.

Joshua, to me, the flicker seems to be pretty much the same regardless of the number of videos I selected ( 6 ~ 7 videos), but I do see missing highlight behavior (just the border is shown), which definitely look like an issue.  Do you see any relationship between the number of selected videos and flicker behavior on your side?

Comment 11

[Joshua Mitchell (Inactive)]

I'm not seeing any relationship or consistency between the number of videos and when the blue flicker is absent. I experience the missing highlight multiple times in a row and then not at all for 10 or so taps all on the same video. It happens when only selecting the same video over and over, or selecting multiple videos. There does not seem to be any relationship between number of videos, number of times selected, if the videos are all in a row or spaced out, landscape vs portrait or any other variation.

Comment 12

[David Flanagan [:djf]]

Russ,

Do you have time to take a look at this and consider reducing the amount of highlighting that happens. I'm guessing this is just a :active CSS thing that is easy to change.  We'll need to coordinate with UX to get approval for the change, of course, but if gecko is being weird on us here, it would be nice to workaround it and get the (simple) fix into 2.2

Comment 13

[Russ Nicoletti [:russn]]

I haven't looked at the css but what I observed when selecting thumbnails is that if you tap and hold the thumbnail, the background becomes blue. When you then lift your finger, there will be no flashing. It seems the flashing is the background quickly transitioning from blue to transparent. In any event, I will look into changing the behavior so there is no flashing.

Comment 14

[GitHub Autolander Bot]

Attachment: [gaia] russnicoletti:bug-1013594 > mozilla-b2g:v2.2

Comment 15

[Russ Nicoletti [:russn]]

Comment on attachment 8593681 [details] [review]
[gaia] russnicoletti:bug-1013594 > mozilla-b2g:v2.2

This patch removes the "active" behavior when selecting thumbnails, meaning the background no longer changes and the text no longer gets highlighted. As such, there is no feedback when selecting a thumbnail until the tap is complete. This is consistent with the gallery behavior. 

Stephanie, are you ok with this change? As I mentioned, this behavior is consistent with gallery and there is no longer an annoying flash when selecting video thumbnails.

Comment 16

[David Flanagan [:djf]]

Comment on attachment 8593681 [details] [review]
[gaia] russnicoletti:bug-1013594 > mozilla-b2g:v2.2

Technical r+ if we get UI approval to land it. If UX signs off in time, let's request 2.2 uplift for this as well.

Comment 17

[GitHub Autolander Bot]

Attachment: [gaia] russnicoletti:bug-1013594 > mozilla-b2g:master

Comment 18

[Russ Nicoletti [:russn]]

Comment on attachment 8594244 [details] [review]
[gaia] russnicoletti:bug-1013594 > mozilla-b2g:master

This PR is against master. Same code change as the 2.2 patch from comment 15.

Comment 19

[Amy Lee [:amylee] UX]

Comment on attachment 8594244 [details] [review]
[gaia] russnicoletti:bug-1013594 > mozilla-b2g:master

Hi, 

This looks better with the blue overlay removed. Thanks

Comment 20

[Russ Nicoletti [:russn]]

Master: https://github.com/mozilla-b2g/gaia/commit/3852f5dc70864d4362289b32e163174f1308bd6e

Comment 21

[Russ Nicoletti [:russn]]

Comment on attachment 8594244 [details] [review]
[gaia] russnicoletti:bug-1013594 > mozilla-b2g:master

[Approval Request Comment]

[Bug caused by] (feature/regressing bug #): not a regression

[User impact] if declined: Bad user experience, reflects badly on FireoxOS

[Testing completed]: Unit testing, manual testing

[Risk to taking this patch] (and alternatives if risky): Low risk, the patch consists of the removal of some CSS in video app that applies only to when thumbnail are selected

[String changes made]: none

Comment 22

[bhavana bajaj [:bajaj]]

Comment on attachment 8594244 [details] [review]
[gaia] russnicoletti:bug-1013594 > mozilla-b2g:master

approving this long standing issue given the low risk patch. Any fallouts , please back this out.

Comment 23

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/952934949cd16f4c4e27196a3f169e5a2e21c24f

Comment 24

[Shally Li（leave from Mozilla）]

This bug has been verified as pass on latest build of Flame v2.2&3.0 and Nexus 5 v2.2&3.0 by the STR in Comment 0.

Actual results: Videos are selected as indicated by blue bounding box and are not flickering.
See attachment: verified_v2.2&3.0.mp4
Reproduce rate: 0/20

----------------------------------------------------------------------------------
Device: Flame v2.2 build(Pass)
Build ID               20150511002500
Gaia Revision          528ef60e7cda09ad43478065f5d33bda398fbeb7
Gaia Date              2015-05-08 23:40:58
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/8d04cc085cf5
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150511.035847
Firmware Date          Mon May 11 03:58:59 EDT 2015
Bootloader             L1TC000118D0

Device: Flame v3.0 build(Pass)
Build ID               20150511160205
Gaia Revision          6089234ace8b294a8feef064387604bae16254e3
Gaia Date              2015-05-10 13:57:12
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/502e1a5e722f
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150511.193556
Firmware Date          Mon May 11 19:36:04 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 v2.2 build (Pass)
Build ID               20150511002500
Gaia Revision          528ef60e7cda09ad43478065f5d33bda398fbeb7
Gaia Date              2015-05-08 23:40:58
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/8d04cc085cf5
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150511.034716
Firmware Date          Mon May 11 03:47:32 EDT 2015
Bootloader             HHZ12f

Device: Nexus 5 v3.0 build (Pass)
Build ID               20150511160205
Gaia Revision          6089234ace8b294a8feef064387604bae16254e3
Gaia Date              2015-05-10 13:57:12
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/502e1a5e722f
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150511.193757
Firmware Date          Mon May 11 19:38:13 EDT 2015
Bootloader             HHZ12f

Comment 25

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.2&3.0.mp4