101364 - Disable quick launch for multiple profiles on 094pdt managed branch

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Suresh Duddi (gone)]

bug 98182

I think the safest approach (if this fix is low risk) is to disable turbo for
multiple profiles. We also need to think about:
- do we need to resurrect the dialog on last window close the turbo is ON
- Any wording changes in installer

Comment 1

[Suresh Duddi (gone)]

Nominating for PDT

Comment 2

[Conrad Carlen (not reading bugmail)]

Working on it.

Comment 3

[Conrad Carlen (not reading bugmail)]

Attachment: patch

Comment 4

[Conrad Carlen (not reading bugmail)]

Back to 6.1 behavior - if there are multiple profiles and we're launched with
-turbo, we don't launch. Also, if we have multiple profiles, the QuickLaunch
business is not shown at all in the prefs because (1) it can't be used in that
case so why show it and (2) if it were shown and somebody with multiple profiles
turned it on, code would have to be added in more places to prevent it from
having any effect. The on-closing-last-window dialog text is back to its former
6.1 state of warning that you're still connected to everything.

Comment 5

[(Don't use, old account) - Kai Engert]

I can confirm, that with this patch, the nsNSSComponent no longer receives
profile switch events (I tested it).

Comment 6

[Suresh Duddi (gone)]

Comment on attachment 50660 [details] [diff] [review]
patch

r=dp

Comment 7

[Suresh Duddi (gone)]

Bill, could you review this too please.

Comment 8

[Conrad Carlen (not reading bugmail)]

One thing I need help with: My VPN connection is down and therefore no NS tree
right now. The changed string in turboDialog.dtd should be different for NS: the
string for moz shouldn't mention IM whereas the one for NS should.

Comment 9

[Bill Law]

I looked this patch over pretty carefully.  It looks good to me.

Comment 10

[Alec Flett]

Comment on attachment 50660 [details] [diff] [review]
patch

Aw, too bad, I liked this feature :)
sr=alecf

Comment 11

[Jesse Ruderman]

Is this bug just for the 0.9.4 branch?  If so, the summary should reflect that.

Comment 12

[Krishna Mohan]

I applied this patch in association with Simple MAPI code (95117, 98566) and I 
found a regression in Simple MAPI behaviour.  I spoke to Bill Law and Conrad 
Carlen on this.

When Mapi clients invokes mozilla (always in turbo mode) if there are multiple 
profiles then mozilla won't come up.  A better solution would be setting up a 
default profile with some heuristic (last selected profile/user selected default 
profile/the first prifile in the list).

Comment 13

[Jaime Rodriguez, Jr.]

WE believ the way this should, is, that if there is no browser running, and
someone does a MAPI request, than a profile picker should come up. There should
not be a dependency of Simple MAPI on Turbo.

Comment 14

[Conrad Carlen (not reading bugmail)]

MAPI is supposed to be able to bring up the application, and have it do
something  without the application being seen. If MAPI does not depend on
-turbo, which I think it shouldn't, it wouldn't be able to do the "unseen" mode.

Comment 15

[Jaime Rodriguez, Jr.]

Conrad - Let's discuss this one @ PDT tomorrow @ noon.

Comment 16

[Jaime Rodriguez, Jr.]

check it in - PDT+

Comment 17

[Conrad Carlen (not reading bugmail)]

checked into branch

If you have multiple profiles:
app will not launch at Windows boot time
quicklaunch is not visible in prefs so can't be turned on
if you have only 1 profile and then make a 2nd, quicklaunch gets disabled

If you have 1 profile, the QuickLaunch dialog which shows on the first exit has
the bit it had in 6.1 about still being connected.

Comment 18

[Grace Bush]

verified on NT and Win2000- with build 2001092805 branch

all ccarlens steps were verified
if you have multiple profiles and delete them all, the single profile left -
does allow for turbo to be turned on in prefs....
now you don't see it- now you do! Cool