Incorrectly handling of ErrorEvent in unittest (event.data)

RESOLVED FIXED in mozilla32

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: seward.zheng, Assigned: seward.zheng)

Tracking

unspecified
mozilla32
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

5 years ago
In some unit tests, worker's onerror handler does not correctly handle ErrorEvent.

e.g.: dom/workers/test/test_fileReaderSync.xul

Line 164:
     worker.onerror = function(event) {
       ok(false, "Worker had an error: " + event.data);
       finish();
     };
event does not have data property, should have event.message instead.
Assignee

Comment 1

5 years ago
Posted patch PatchSplinter Review
A patch.
Assignee: nobody → szheng
Status: NEW → ASSIGNED
Attachment #8427532 - Flags: review?(khuey)
Assignee

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c27a2ec18d12
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.