Closed Bug 1013691 Opened 10 years ago Closed 9 years ago

Clean up TBPL symbols

Categories

(Tree Management Graveyard :: TBPL, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: RyanVM, Unassigned)

References

Details

Attachments

(3 files)

reftest and reftest-sanity are currently sharing symbols. I'm going to turn reftest-sanity into Rs.

Also, the Gaia OOP tests are a pile of G-oop at the moment and need to look better. Also, it's been suggested that the symbols should get some changing around to better reflect what they are, especially now that Gaia-Try is working to replace Travis.
Especially with the Gaia Try work progressing, I think the time to make these symbol changes for people transitioning from Travis to TBPL is now.

Unless we don't think we need them after all and want to stick with the current ones for the various Gaia test suites.
Had an IRC chat with various Gaia test stakeholders today and I think we reached a basic consensus on the changes to make:

G -> Gu (description will remain Gaia Unit Tests)
Gi -> Gij (description will change to Gaia JS Integration Tests)
Gu -> Gip (description will change to Gaia Python Integration Tests)

Gb and Li will stay as-is.

If the above sounds good to everyone CCed here, I think that's a workable way forward!
BTW, it's unlikely I'll be able to change the buildbot names for the jobs (creates pain for questionable gain), so we'll have to live with those anyway.
Good for me :)
Attachment #8450219 - Flags: review?(emorley)
Attachment #8450219 - Flags: review?(emorley) → review+
Comment on attachment 8450226 [details] [diff] [review]
change Gaia unit test naming and symbols

Review of attachment 8450226 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with using end of line anchors ($) where possible, to make these more robust when moved to treeherder + double checking with &debug=1 after this patchset is applied.
Attachment #8450226 - Flags: review?(emorley) → review+
First two parts pushed:
https://hg.mozilla.org/webtools/tbpl/rev/be6dc427bf80
https://hg.mozilla.org/webtools/tbpl/rev/42a2fa73a557

And a follow-up to add some end of line anchors:
https://hg.mozilla.org/webtools/tbpl/rev/dd91d8ad1d37

Leaving this bug open for more to come.
Keywords: leave-open
Depends on: 1037175
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #8)

In production.
I special-cased the shell version to show up in the SM() group along with the other shell jobs. I've confirmed that debug=1 comes up clean and existing jobs on TBPL show up correctly (including a Try run of the shell version).

I'll hold off on landing this until after sfink gets back from PTO and confirms that he's happy with this.
Attachment #8465474 - Flags: review?(emorley)
Attachment #8465474 - Flags: feedback?(sphink)
Comment on attachment 8465474 [details] [diff] [review]
use a consistent H symbol for Hazard Analysis jobs

Review of attachment 8465474 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #8465474 - Flags: review?(emorley) → review+
Status: NEW → ASSIGNED
Comment on attachment 8465474 [details] [diff] [review]
use a consistent H symbol for Hazard Analysis jobs

Review of attachment 8465474 [details] [diff] [review]:
-----------------------------------------------------------------

This is great, ship it!

Thanks.
Attachment #8465474 - Flags: feedback?(sphink) → feedback+
https://hg.mozilla.org/webtools/tbpl/rev/06af9dad7e20

So looking back at comment 0, I think all that's left for here is the OOP test situation.
Depends on: 1052472
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #13)
> https://hg.mozilla.org/webtools/tbpl/rev/06af9dad7e20

In production.
Product: Webtools → Tree Management
TBPL has been EOLed (bug 1054977).
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → INCOMPLETE
Assignee: ryanvm → nobody
Product: Tree Management → Tree Management Graveyard
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: