1013720 - Bundle JS folder for components at build time

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Kevin Grandon :kgrandon]

It would be useful to bundle the js/ folder inside of a component during build time for more complex standalone components.

For the grid example we have several JS files that should be loaded by the component if possible, so we should explore doing so.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Yuren - could you take a quick look at this? The test is rather brittle due to the current mocks, but I'm not really sure what's best to do there. It seems like we may want to be able to create a more realistic directory object?

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8426004 [details] [review]
Github pull request

reassign to George since I got too much review requests :-/

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Hi Kevin,
This patch looks good to me,
but I'm wondering, the only folder of component we don't copy is "examples", right?
Why not just set an ignoring list (only example so far) and copy the rest of resource into shared?

Comment 4

[Kevin Grandon :kgrandon]

I think that may be an option in the future, but I think whitelisting is generally a better practice for now as we might be adding a test/ folder into each component, or other folders we don't want to be on the device.

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8426004 [details] [review]
Github pull request

The unit test should be able to filter out unnecessary files. However, there's still some issues of the mockUtils.getFile(), the append function doesn't work. I'll file another bug to fix it.

For the rest parts, it looks good. r=gduan

Comment 6

[Kevin Grandon :kgrandon]

Thanks a lot! https://github.com/mozilla-b2g/gaia/commit/50c0a91798dbe02c08961f3fee5ce2ebe8d7f9ab