1013734 - [Flame]Need parameter/configuration support to change power-off charging mode

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Vendcom, defect)

Description

[Mike Lien[:mlien]]

[Device]
  Flame

[Reproduction build]
  v10F-3

[Description]
From current behavior, power-off then charging will go into charging mode
Some people need previous behavior (power-on automatically), if we have chance to add parameter/configuration to control the charging mode?
Or if any patch to revert this behavior?

More detailed request please refer to bug 997087 comment 5

Comment 1

[Mike Lien[:mlien]]

hi yanan, could you help to provide your comment about this issue

Comment 2

[Tony Zhao]

Hi Mike,

We can provide a patch to revert behavior of power up by insert charger, but will need some time to prepare. Probably can be ready next week.
Thanks

Comment 3

[Andrew Halberstadt [:ahal]]

Just to clarify, I believe we want to keep the current behaviour for certain builds, and revert it for others. So if there was a kernel parameter or something as per https://bugzilla.mozilla.org/show_bug.cgi?id=997087#c7, that would be ideal.

Comment 4

[Tony Zhao]

Attachment: aboot-disable-charger.img

Hi Mike& Andrew,

We have made new aboot image, after flash it by 'fastboot flash aboot aboot-disable-charger.img' then reboot device by pull out battery, device will to previous behavior. If want change it back, just need re-flash normal aboot.
It this ok for you?
Thanks

Comment 5

[Mike Lien[:mlien]]

(In reply to Tony Zhao from comment #4)
> Created attachment 8426967 [details]
> aboot-disable-charger.img
> 
> Hi Mike& Andrew,
> 
> We have made new aboot image, after flash it by 'fastboot flash aboot
> aboot-disable-charger.img' then reboot device by pull out battery, device
> will to previous behavior. If want change it back, just need re-flash normal
> aboot.
> It this ok for you?
> Thanks

Hi yanan, it's cool and fine to me

Comment 6

[Andrew Halberstadt [:ahal]]

Pretty sure this works, but webqa will likely be setting it up, so let's hear from them (re: comment 4)

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Andrew Halberstadt [:ahal] from comment #6)
> Pretty sure this works, but webqa will likely be setting it up, so let's
> hear from them (re: comment 4)

If this is a one-time thing, then we can do this; if we'll need to do this every time the vendor's base build is updated, though, that'll be a scaling problem, I'd think.

Comment 8

[cmtalbert]

(In reply to Stephen Donner [:stephend] from comment #7)
> If this is a one-time thing, then we can do this; if we'll need to do this
> every time the vendor's base build is updated, though, that'll be a scaling
> problem, I'd think.
Exactly. So that we aren't stuck on a one-off boot image, then we'd like to have a patch we can apply to the build so that we can generate this no-charge boot image on demand regardless of what partner boot changes occur.  Since you created the boot image can you just attach the patch that differs this from the standard boot image?

Thanks!

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Clint Talbert ( :ctalbert ) from comment #8)

> Exactly. So that we aren't stuck on a one-off boot image, then we'd like to
> have a patch we can apply to the build so that we can generate this
> no-charge boot image on demand regardless of what partner boot changes
> occur.  Since you created the boot image can you just attach the patch that
> differs this from the standard boot image?
> 
> Thanks!

Tony, can you provide us with the above, please?  Thanks.

Comment 10

[[e-mail]]

Hi, everyone:
  I am Xiaohui Ma from t2m. I has modified this problem, you can modify as follow:
  bootable/bootloader/lk/app/aboot/aboot.c, function update_cmdline
change
-       } else if (target_pause_for_battery_charge()) {
to
+       } else if (device.charger_screen_enabled && target_pause_for_battery_charge()) {
then make aboot.

Now, you can config power off charge. Steps as follow:
fastboot oem enable-charger-screen /*enable power off charge*/
fastboot oem disable-charger-screen /*disable power off charge*/
prove this:
fastboot oen device-info, 
ouput like this:
...
(bootloader) 	Charger screen enabled: true
...

power off charge is on.
Thanks.

Comment 11

[Tony Zhao]

Hi Stephen& Clint, 

Please check the information from comment #10, thanks

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Tony Zhao from comment #11)
> Hi Stephen& Clint, 
> 
> Please check the information from comment #10, thanks

Thanks; I still don't know how we can get that patch into the engineering builds we use, but looks like we should be able to do the fastboot commands, once that's in, in Dave's flash script, which we use: https://gist.github.com/davehunt/f390693d59d285ea22da

Comment 13

[Francis Lee [:frlee]]

hi Stephen,

please refer to T2M's reply below: 

     Can you compile image in your environment? If you can, modify code as comment 10, then compile as follows:
source build/envsetup.sh
lunch msm8610-eng
make aboot
then download aboot image,
first go to fastboot mode, then
fastboot flash aboot xxx/out/target/product/msm8610/emmc_appsboot.mbn
You can configure power off charger via fastboot cmds.

Comment 14

[youlong.jiang]

has upload conde to github

tks.

Comment 15

[raymond [:retornam] (inactive)]

(In reply to youlong.jiang from comment #14)
> has upload conde to github
> 
> tks.

Which repo or branch?

Comment 16

[Andrew Halberstadt [:ahal]]

(In reply to youlong.jiang from comment #14)
> has upload conde to github
> 
> tks.

Hi Xiaohui, does this comment mean that the fix is merged into your upstream repositories and we no longer need to apply the patch manually? Thanks!

Andrew

Comment 17

[youlong.jiang]

hi all,

    for this issue, the latest eng building v123-2 is ok. pls have a try and feedback.

tks.

Comment 18

[Gautam Akiwate [:gakiwate]]

I tested with the builds in
https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2gotoro/nightly/mozilla-b2g32_v2_0-flame-eng/latest/
Used: b2g-32.0.en-US.android-arm.tar.gz and gaia.zip

Test Method and Observation:
1. Power Off Device
2. Connect Device to USB Charging
3. Device goes to Charging Mode

I do not see the intended behavior of booting up automatically.

Comment 19

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Gautam Akiwate [:gakiwate] from comment #18)
> I tested with the builds in
> https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2gotoro/nightly/mozilla-
> b2g32_v2_0-flame-eng/latest/
> Used: b2g-32.0.en-US.android-arm.tar.gz and gaia.zip
> 
> Test Method and Observation:
> 1. Power Off Device
> 2. Connect Device to USB Charging
> 3. Device goes to Charging Mode
> 
> I do not see the intended behavior of booting up automatically.

Did you flash with the vendor/base build (V123), first, though?

Comment 20

[Gautam Akiwate [:gakiwate]]

I used https://intranet.mozilla.org/QA/B2G_Tips_and_Tricks#latest_OEM_build:_v123_.2B_fonts to flash the v123 build.

Also, I can use the fastboot commands as listed in comment #10. Just to be sure, I tested by using both the fastboot commands.

However, in both cases the results stays the same.

    mozilla@gakiwate:~/Projects/Mozilla/b2g-flash/b2g-distro$ fastboot oem disable-charger-screen
    ...
    OKAY [  0.010s]
    finished. total time: 0.010s
     
    mozilla@gakiwate:~/Projects/Mozilla/b2g-flash/b2g-distro$ fastboot oem device-info
    ...
    (bootloader)    Device tampered: false
    (bootloader)    Device unlocked: false
    (bootloader)    Charger screen enabled: false
    OKAY [  0.005s]
    finished. total time: 0.005s
     
    mozilla@gakiwate:~/Projects/Mozilla/b2g-flash/b2g-distro$ fastboot oem enable-charger-screen
    ...
    OKAY [  0.010s]
    finished. total time: 0.010s
    mozilla@gakiwate:~/Projects/Mozilla/b2g-flash/b2g-distro$ fastboot oem device-info
    ...
    (bootloader)    Device tampered: false
    (bootloader)    Device unlocked: false
    (bootloader)    Charger screen enabled: true
    OKAY [  0.005s]
    finished. total time: 0.005s

Comment 21

[cmtalbert]

Youlong Jiang, can you take a look at comment 20 above, it appears this latest base build does not solve the issue. Thanks

Comment 22

[Francis Lee [:frlee]]

hi Clint and all,

V123 is production build installed on 5K commercial devices. it doesn't include the fix in engineering build V123-2 (if you check the build number, its a newer build than V123).

T2M claim that they will include this solution in next official release (KK v1.4).
may i know if you really need a production build for this issue?

Comment 23

[BMO Automation]

Firefox OS is not being worked on