1013767 - BasicCompositor reftests on test compositing the entire window

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Matt Woodrow (:mattwoodrow)]

When we readback from BasicCompositor via PCompositor::MakeSnapshot, we always draw the entire window, so we don't get an coverage of composites that are restricted to an invalid region.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Add Matrix::TranslatePost

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Restrict compositing to the size required for snapshots

Comment 3

[Nicolas Silva [:nical]]

Comment on attachment 8426038 [details] [diff] [review]
Restrict compositing to the size required for snapshots

Review of attachment 8426038 [details] [diff] [review]:
-----------------------------------------------------------------

I'd rather avoid the numerous apparitions of nsIntRect but other than that it looks sensible.

::: gfx/layers/Compositor.h
@@ +237,5 @@
>     *
>     * If this method is not used, or we pass in nullptr, we target the compositor's
>     * usual swap chain and render to the screen.
>     */
> +  void SetTargetContext(gfx::DrawTarget* aTarget, const nsIntRect& aRect)

nit: it'd be nice to use gfx::IntRect instead of nsIntRect

Comment 4

[Bas Schouten (:bas.schouten)]

Comment on attachment 8426037 [details] [diff] [review]
Add Matrix::TranslatePost

Review of attachment 8426037 [details] [diff] [review]:
-----------------------------------------------------------------

nit: rename to PostTranslate

Comment 5

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/920b01c26aff
https://hg.mozilla.org/integration/mozilla-inbound/rev/d486b8f1f935

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/920b01c26aff
https://hg.mozilla.org/mozilla-central/rev/d486b8f1f935