Closed Bug 1013767 Opened 6 years ago Closed 6 years ago

BasicCompositor reftests on test compositing the entire window

Categories

(Core :: Graphics: Layers, defect)

29 Branch
x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

Details

Attachments

(2 files)

When we readback from BasicCompositor via PCompositor::MakeSnapshot, we always draw the entire window, so we don't get an coverage of composites that are restricted to an invalid region.
Attachment #8426037 - Flags: review?(bas)
Blocks: 1013769
Comment on attachment 8426038 [details] [diff] [review]
Restrict compositing to the size required for snapshots

Review of attachment 8426038 [details] [diff] [review]:
-----------------------------------------------------------------

I'd rather avoid the numerous apparitions of nsIntRect but other than that it looks sensible.

::: gfx/layers/Compositor.h
@@ +237,5 @@
>     *
>     * If this method is not used, or we pass in nullptr, we target the compositor's
>     * usual swap chain and render to the screen.
>     */
> +  void SetTargetContext(gfx::DrawTarget* aTarget, const nsIntRect& aRect)

nit: it'd be nice to use gfx::IntRect instead of nsIntRect
Attachment #8426038 - Flags: review?(nical.bugzilla) → review+
Comment on attachment 8426037 [details] [diff] [review]
Add Matrix::TranslatePost

Review of attachment 8426037 [details] [diff] [review]:
-----------------------------------------------------------------

nit: rename to PostTranslate
Attachment #8426037 - Flags: review?(bas) → review+
https://hg.mozilla.org/mozilla-central/rev/920b01c26aff
https://hg.mozilla.org/mozilla-central/rev/d486b8f1f935
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.