1013780 - should only create displayports during display list building if the display list is for painting to the screen

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Timothy Nikkel (:tnikkel)]

Bug 982141 creates a displayport if one is not set on b2g. We shouldn't create display ports if the display list we are building is for something other than painting to the screen.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: patch

We set the IsPaintingToWindow flag only in nsLayoutUtils::PaintFrame with the right flags.

Comment 2

[Botond Ballo [:botond]]

Comment on attachment 8426048 [details] [diff] [review]
patch

Review of attachment 8426048 [details] [diff] [review]:
-----------------------------------------------------------------

Out of curiosity, for what other purposes than painting to the screen do we build display lists?

Comment 3

[Timothy Nikkel (:tnikkel)]

http://mxr.mozilla.org/mozilla-central/source/layout/base/nsDisplayList.h?rev=75b4665ce6b0#131
Painting (besides painting to the screen we also have potential drawWindow calls), event delivery (to determine what is at a given point to deliver events (mouse clicks, touches) to it), plugin geometry (to set the clip on the native widgets for plugins, but I think we re-use the painting display list for this now), image visibility (determining which images are nearly visible), and then other which looks like it's just used in one place to get the transform for a transformed element by using a nsDisplayTransform item for async transforms.

Comment 4

[Timothy Nikkel (:tnikkel)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f4b90f52ada2
And silly bustage fixup because I fixed it locally but the change got into the wrong patch in my queue
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1135a801e39

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f4b90f52ada2
https://hg.mozilla.org/mozilla-central/rev/c1135a801e39