Closed Bug 1013780 Opened 6 years ago Closed 6 years ago

should only create displayports during display list building if the display list is for painting to the screen

Categories

(Core :: Panning and Zooming, defect)

29 Branch
x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(1 file)

Bug 982141 creates a displayport if one is not set on b2g. We shouldn't create display ports if the display list we are building is for something other than painting to the screen.
Attached patch patchSplinter Review
We set the IsPaintingToWindow flag only in nsLayoutUtils::PaintFrame with the right flags.
Attachment #8426048 - Flags: review?(botond)
Comment on attachment 8426048 [details] [diff] [review]
patch

Review of attachment 8426048 [details] [diff] [review]:
-----------------------------------------------------------------

Out of curiosity, for what other purposes than painting to the screen do we build display lists?
Attachment #8426048 - Flags: review?(botond) → review+
http://mxr.mozilla.org/mozilla-central/source/layout/base/nsDisplayList.h?rev=75b4665ce6b0#131
Painting (besides painting to the screen we also have potential drawWindow calls), event delivery (to determine what is at a given point to deliver events (mouse clicks, touches) to it), plugin geometry (to set the clip on the native widgets for plugins, but I think we re-use the painting display list for this now), image visibility (determining which images are nearly visible), and then other which looks like it's just used in one place to get the transform for a transformed element by using a nsDisplayTransform item for async transforms.
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4b90f52ada2
And silly bustage fixup because I fixed it locally but the change got into the wrong patch in my queue
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1135a801e39
https://hg.mozilla.org/mozilla-central/rev/f4b90f52ada2
https://hg.mozilla.org/mozilla-central/rev/c1135a801e39
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Depends on: 1151663
You need to log in before you can comment on or make changes to this bug.