1013803 - NFC: TypeError: suite.skip is not a function when running Gaia Unit test.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

When running Gaia unit test for NFC, I found there's one error in console,
"JavaScript error: http://system.gaiamobile.org:8080/test/unit/nfc_manager_test.js?time=1400656542618, line 455: suite.skip is not a function"

However the unit test is still passed, not sure what this error message is.

Comment 1

[Krzysztof Mioduszewski[:tauzen]]

This is my error. I think we don't support suite.skip in unit tests. The test passes because suit.skip is the last one in the file, so the other ones are working properly. To remove this warning i can comment out the skipped test.

Comment 2

[Krzysztof Mioduszewski[:tauzen]]

I've rewrote the test a bit and moved it (still commented) to be part of the proper test case.

I've also fixed this error - "JavaScript error: http://system.gaiamobile.org:8080/js/nfc_manager.js?time=1400659244941, line 47: window.navigator.mozSetMessageHandler is not a function", by removing the unnecessary requireApp('system/js/nfc_manager.js');

The fix is waiting for TravisCI build here: https://github.com/mozilla-b2g/gaia/pull/19467/files

Comment 3

[Krzysztof Mioduszewski[:tauzen]]

Attachment: pull-request-1013803.txt

Comment 4

[Carsten Book [:Tomcat]]

master : https://github.com/mozilla-b2g/gaia/commit/7ef9aa348bf3328be255c566e58c472689e0bec1