1013907 - content/media/webrtc/LoadMonitor.cpp:312:32: error: '_SC_CLK_TCK' was not declared in this scope (on *BSD platforms)

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Jan Beich]

Attachment: fix ifdefs

clang 3.4.1

In file included from content/media/webrtc/Unified_cpp_content_media_webrtc0.cpp:28:
content/media/webrtc/LoadMonitor.cpp:312:32: error:
      use of undeclared identifier '_SC_CLK_TCK'
  mTicksPerInterval = (sysconf(_SC_CLK_TCK) * mLoadUpdateInterval) / 1000;
                               ^
In file included from content/media/webrtc/Unified_cpp_content_media_webrtc0.cpp:67:
In file included from content/media/webrtc/MediaEngineWebRTCAudio.cpp:5:
/home/holo/.cache/a/overlay/gecko/www/firefox-nightly/work/mozilla-inbound-7ba8c658dc58/content/media/webrtc/MediaEngineWebRTC.h:345:7: warning:
      private field 'mSamples' is not used [-Wunused-private-field]
  int mSamples; // int to avoid conversions when comparing/etc to samplingFr...
      ^
1 warning and 1 error generated.

gcc 4.8.3

In file included from content/media/webrtc/Unified_cpp_content_media_webrtc0.cpp:28:0:
content/media/webrtc/LoadMonitor.cpp: In member function 'nsresult mozilla::LoadInfo::Init(int)':
content/media/webrtc/LoadMonitor.cpp:312:32: error: '_SC_CLK_TCK' was not declared in this scope
   mTicksPerInterval = (sysconf(_SC_CLK_TCK) * mLoadUpdateInterval) / 1000;
                                ^
content/media/webrtc/LoadMonitor.cpp:312:43: error: 'sysconf' was not declared in this scope
   mTicksPerInterval = (sysconf(_SC_CLK_TCK) * mLoadUpdateInterval) / 1000;
                                           ^

UpdateSystemLoad() needs an implementation using kern.cp_time sysctl.

Comment 1

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8426179 [details] [diff] [review]
fix ifdefs

Review of attachment 8426179 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Will throw it on try.

Comment 2

[Gian-Carlo Pascutto [:gcp]]

https://tbpl.mozilla.org/?tree=Try&rev=83ec23f40c6e

Comment 3

[Landry Breuil (:gaston)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c61733f749ec

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c61733f749ec