1013915 - Clean up module imports/ dependencies and use lazy getters where possible

Status: VERIFIED FIXED

(Firefox :: Translations, defect)

Description

[Mike de Boer [:mikedeboer]]

It'd be worthwhile to go through the module imports in `browser/components/translation/` to clean up and remove unused dependencies.

Comment 1

[Mike de Boer [:mikedeboer]]

Marco, can you add this to the current iteration?

Comment 2

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: clean up module imports/ dependencies and use lazy getters where possible

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 8426196 [details] [diff] [review]
Patch v1: clean up module imports/ dependencies and use lazy getters where possible

Review of attachment 8426196 [details] [diff] [review]:
-----------------------------------------------------------------

The changes in Translation.jsm and TranslationDocument.jsm seem fine to me, although I doubt the lazy module getters really save us anything here (I would expect Services.jsm to have its compartment created near startup, and CommonUtils to be imported as soon as BingTranslator.jsm is used).

::: browser/components/translation/BingTranslator.jsm
@@ -7,5 @@
>  const {classes: Cc, interfaces: Ci, utils: Cu} = Components;
>  
>  this.EXPORTED_SYMBOLS = [ "BingTranslation" ];
>  
> -Cu.import("resource://gre/modules/Services.jsm");

Services.jsm is indeed unused here.

@@ +12,4 @@
>  Cu.import("resource://gre/modules/Log.jsm");
> +
> +XPCOMUtils.defineLazyModuleGetter(this, "Promise",
> +                                  "resource://gre/modules/Promise.jsm");

I think these lazy getters add overhead here, as BingTranslator.jsm is imported only when we are about to perform a translation; not at startup.

Comment 4

[Marco Mucci [:MarcoM]]

Added to Iteration 32.2

Comment 5

[Mike de Boer [:mikedeboer]]

Attachment: Patch v2: remove unused imports

Carrying over r=florian.

Pushed to fx-team as: https://hg.mozilla.org/integration/fx-team/rev/9f7d9d5c9261

Comment 6

[Ryan VanderMeulen [:RyanVM]]

This landed with an incorrect bug number, FWIW.
https://hg.mozilla.org/mozilla-central/rev/9f7d9d5c9261