Closed Bug 1014042 Opened 6 years ago Closed 6 years ago

Add compositor benchmark

Categories

(Core :: Graphics: Layers, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: BenWa, Assigned: BenWa)

References

Details

Attachments

(1 file, 3 obsolete files)

Attached patch patch (obsolete) — Splinter Review
A simple framework where we can quickly quantify the cost and the performance of graphics operation in the compositor.
Attachment #8426308 - Flags: review?(jmuizelaar)
Attachment #8426308 - Flags: review?(jmuizelaar) → review+
Attached patch patch v2 (obsolete) — Splinter Review
Fix b2g build errors.

https://tbpl.mozilla.org/?tree=Try&rev=920448632e85
Assignee: nobody → bgirard
Attachment #8426308 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8426388 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/344f0e4b126c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Blocks: 998438
Blocks: 1016678
Attached patch patch v3 (obsolete) — Splinter Review
Attachment #8426388 - Attachment is obsolete: true
Attachment #8434514 - Flags: review?(jmuizelaar)
Attached patch patch v4Splinter Review
Attachment #8434514 - Attachment is obsolete: true
Attachment #8434514 - Flags: review?(jmuizelaar)
Attachment #8434517 - Flags: review?(jmuizelaar)
Comment on attachment 8434517 [details] [diff] [review]
patch v4

Review of attachment 8434517 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/CompositorBench.cpp
@@ +215,5 @@
> +  virtual void Setup(Compositor* aCompositor, size_t aStep) {
> +    int bytesPerPixel = 4;
> +    size_t w = 256;
> +    size_t h = 256;
> +    mBuf = (uint32_t *) malloc(w * h * sizeof(uint32_t));

You could use new to have types...
Attachment #8434517 - Flags: review?(jmuizelaar) → review+
Opps, this patch should of went to bug 1016678.
You need to log in before you can comment on or make changes to this bug.