1014043 - [B2G][v1.4]Fail to call from Call log and error message is 'Airplane mode activated' when only sim 2 exists

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P3)

Description

[helloarvin]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.116 Safari/537.36

Steps to reproduce:

1) Slot 1 is empty and insert one sim card to slot 2
2) boot the phone and open dailer app
3) click into Call log and select one record to call(you can call 10086 first if call log is empty) 


Actual results:

Fail to call and error message is 'Airplane mode activated'.(note: we can make call successfully from dial panel all times)


Expected results:

Call successed from call log under this case

Comment 1

[helloarvin]

Attachment: fix_error_handling_on_sim2_only.patch

root-casue: We will check the length of iccIds before a call made from Call log and if its value is no more than two, the call will be established directly with the param of cardIndex is 0.

solution: we should deal with the case of iccIds length is 0 and 1 separately. The call could be made directly if there's no sim card currently the call, but if current length of iccIds is 1, we have to get the cardIndex of current available sim card so that the call can be established successfully.

Comment 2

[Etienne Segonzac (:etienne)]

Comment on attachment 8426334 [details] [diff] [review]
fix_error_handling_on_sim2_only.patch

Review of attachment 8426334 [details] [diff] [review]:
-----------------------------------------------------------------

Can you update phone_action_menu_test.js to reflect this change? Thanks!

::: apps/communications/dialer/js/phone_action_menu.js
@@ +49,1 @@
>          CallHandler.call(_newPhoneNumber, 0);

I don't think we need this case anymore.
Looks like we're saying: "if there are no sim cards, use the first one" :)

Comment 3

[helloarvin]

Attachment: update_fix_error_handling_on_sim2_only.patch

Hi Etienne,

  Yeah, that's right. We do not need this case any more and I've modified the patch as you suggest.

  Besides, I think there's no need to update phone_action_menu_test.js because the modification just changes the card index on the single sim card case.

  Please let me know if anything need to be improved. Thanks a lot.

Comment 4

[Anthony Ricaud (:rik)]

attachment 8426972 [details] [diff] [review] is a 1.4 only patch here. In 2.0, we don't have the call option in phone_action_menu anymore. I think we should go with the simplest patch possible. The simplest one is to not send a serviceId to CallHandler.call.

Let me provide a 1.4 and 2.0 patch for that.

Comment 5

[Anthony Ricaud (:rik)]

Attachment: 2.0 patch

Comment 6

[Anthony Ricaud (:rik)]

Attachment: 1.4 patch

Comment 7

[Etienne Segonzac (:etienne)]

Comment on attachment 8426999 [details] [review]
2.0 patch

If we do this we should remove the FIXME and close bug 982163 right?

Comment 8

[Anthony Ricaud (:rik)]

(In reply to Etienne Segonzac (:etienne) from comment #7)
> If we do this we should remove the FIXME and close bug 982163 right?
You're right, I've updated the two patches accordingly.

Comment 9

[Anthony Ricaud (:rik)]

master: https://github.com/mozilla-b2g/gaia/commit/1b52378d005f88ccbf47cb83954c49e6084b62e8
1.4: https://github.com/mozilla-b2g/gaia/commit/172acbe168c263e5cda6f8125aa18873e9ecc3a4

Comment 10

[helloarvin]

Hi Anthony,

It seems that the patch for v1.4 raised a new issue that ---'it will always ask user to select sim before calling in call log even if the default sim for outgoing call had been set yet'.

I think we' better add the judgement of current cardIndex got from 'ril.telephony.defaultServiceId' and if its value is '-1'(two possible case: 'no sim' or 'always ask') we should call CallHandler.call directly with no asking.

Just like:
https://github.com/mozilla-b2g/gaia/blob/v1.4/apps/communications/dialer/js/phone_action_menu.js#L52
---->
if (cardIndex === -1 || navigator.mozIccManager.iccIds.length <= 1) {
  ... ...

How do you think?

Please feel free to point out if there's anything wrong, thanks.

Comment 11

[Anthony Ricaud (:rik)]

This was originally designed that way because we thought bug 920011 would be in 1.4 too. I agree with you that without bug 920011 fixed in 1.4, it would make more sense to respect the user setting.

Please open a new bug and nominate it for blocking 1.4.

Comment 12

[helloarvin]

(In reply to Anthony Ricaud (:rik) from comment #11)
> This was originally designed that way because we thought bug 920011 would be
> in 1.4 too. I agree with you that without bug 920011 fixed in 1.4, it would
> make more sense to respect the user setting.
> 
> Please open a new bug and nominate it for blocking 1.4.

Yeah, i've filed a new bug to track:https://bugzilla.mozilla.org/show_bug.cgi?id=1033127

Comment 13

[Brogan Zumwalt [Inactive]]

New test case needs to be written to address bug.

Comment 14

[KTucker [:KTucker][Inactive 3/4/2016]]

Test case has been added to moztrap:

https://moztrap.mozilla.org/manage/case/14367/