Closed Bug 1014057 Opened 10 years ago Closed 10 years ago

Remove inline style elements

Categories

(addons.mozilla.org Graveyard :: Code Quality, defect, P4)

Product:
addons.mozilla.org Graveyard
Component:
Code Quality
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: clouserw, Unassigned)

References

Details

If I grep for "style=" in our root there are about a dozen hits of inline styles.  Until we remove those our CSP policies are weaker than they need to be.

Once this closes, investigate removing the 'unsafe-inline' policy from the script-src directive.  Right now that's https://github.com/mozilla/olympia/blob/master/lib/settings_base.py#L1211 but look for CSP_STYLE_SRC if it moves around
Thanks for filing this.  Due to resource constraints we are closing bugs which we won't realistically be able to fix.  If you have a patch that applies to this bug please reopen.

For more info see http://micropipes.com/blog/2014/09/24/the-great-add-on-bug-triage/
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.