1014161 - input type=file is broken?

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Karen Rudnitski [:kar]]

I can't seem to upload a picture to a Facebook status or to Ottawa.kijiji.ca or usedottawa.ca. it just hangs and doesn't upload, but I can still navigate and input text into fields. 

I used to be able to, but noticed this maybe a week or so ago? Works on beta, but nightly is broken.

Comment 1

[Wesley Johnston (:wesj)]

Does the filename appear in the textbox? If not, what app are you getting the file from? i.e. Gallery/Documents/etc?

Comment 2

[Karen Rudnitski [:kar]]

Nothing happens. Nothing at all. No'loading' action from the browser, nothing. I tried using the gallery, documents and photos for uploading to usedottawa and kijiji with no success. Tried the gallery for Facebook and nothing happened, just a placeholder in that case

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Wes - Is this related to other uploading/attaching bugs?

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Karen, can you try on nightly? bug 1001851 just landed on beta

Comment 5

[Aaron Train [:aaronmt]]

On Nightly on a basic file upload test-site [1], I get the ChooserActivity on tap of 'browse', I select 'Documents' (Android 4.4.2), select a file but do not see it selected in the input. I suspect this is the problem that Karen is seeing on Facebook (haven't tested Facebook or Aurora yet). This works on Firefox 30/29.

On file selection I see in logcat (D/GeckoBrowserApp)

onActivityResult: 7, -1, Intent { dat=content:com.android.providers.downloads.documents/document/1573 flg=0x1 } 

but no errors in console

[1] http://encodable.com/uploaddemo/

Comment 6

[Aaron Train [:aaronmt]]

Made a mistake, I see the same thing on Firefox 30 on that test-page

Comment 7

[Karen Rudnitski [:kar]]

What he said.

Comment 8

[Wesley Johnston (:wesj)]

(In reply to Mark Finkle (:mfinkle) from comment #3)
> Wes - Is this related to other uploading/attaching bugs?

Probably. "Documents" is expected to be broken on 30 (Google changed how things work in KitKat). Use some other app if you're testing there to not confuse this.

Comment 9

[Wesley Johnston (:wesj)]

Attachment: Patch

I thought I was crazy at first and my old patches were somehow busted, but rnewman broke this with the locale switcher :)

This just adds a super.onActivityResult call in this function, but I also made the indentation consistent with our other switch statements (well... I thought I did. I now see that we have a couple different styles scattered around...)

Comment 10

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/643749739862

Comment 11

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/643749739862

Comment 12

[Aaron Train [:aaronmt]]

Too late for 30

Comment 13

[Aaron Train [:aaronmt]]

Beta (file upload behaviour when picking a file through KitKat's Documents) is fixed via bug 1001851. I don't know if this is still needed on mozilla-beta.

Comment 14

[Aaron Train [:aaronmt]]

As is Aurora WFM.

Comment 15

[Richard Newman [:rnewman]]

This onActivityResult block was only added by Bug 917480 in 32, so this patch isn't needed on Aurora or Beta.

Marking as unaffected per Comment 13 and Comment 14. The KK documents issue was a separate bug altogether.