1014181 - Crash when long pressing text selection Actionbar icons on Gingerbread

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

I shoulda caught this in review. Presumably because our menu implementations are very different on GB.

GeckoAppShell: java.lang.NoSuchMethodError: android.view.MenuItem.getActionView
GeckoAppShell: 	at org.mozilla.gecko.ActionModeCompat.onMenuItemLongClick(ActionModeCompat.java:102)
GeckoAppShell: 	at org.mozilla.gecko.widget.GeckoPopupMenu.onMenuItemLongClick(GeckoPopupMenu.java:161)
GeckoAppShell: 	at org.mozilla.gecko.menu.GeckoMenu.access$100(GeckoMenu.java:35)
GeckoAppShell: 	at org.mozilla.gecko.menu.GeckoMenu$2.onLongClick(GeckoMenu.java:230)
GeckoAppShell: 	at android.view.View.performLongClick(View.java:2503)
GeckoAppShell: 	at android.view.View$CheckForLongPress.run(View.java:9065)
GeckoAppShell: 	at android.os.Handler.handleCallback(Handler.java:587)
GeckoAppShell: 	at android.os.Handler.dispatchMessage(Handler.java:92)
GeckoAppShell: 	at android.os.Looper.loop(Looper.java:130)
GeckoAppShell: 	at android.app.ActivityThread.main(ActivityThread.java:3806)
GeckoAppShell: 	at java.lang.reflect.Method.invokeNative(Native Method)
GeckoAppShell: 	at java.lang.reflect.Method.invoke(Method.java:507)
GeckoAppShell: 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:839)
GeckoAppShell: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:597)
GeckoAppShell: 	at dalvik.system.NativeStart.main(Native Method)

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

getActionView wasn't added until Honeycomb, but we implemented our own version for GeckoMenuItem.

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8426555 [details] [diff] [review]
Patch

Review of attachment 8426555 [details] [diff] [review]:
-----------------------------------------------------------------

Have you verified that this works? I've never tried calling an overridden method from a higher API -- I guess it's OK as long as you don't call super?

Comment 3

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/a05f8bb2e876

lost this in my backlog i guess

Comment 4

[Wesley Johnston (:wesj)]

Comment on attachment 8426555 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 943908
User impact if declined: crash on 2.3 devices
Testing completed (on m-c, etc.): landed today
Risk to taking this patch (and alternatives if risky): pretty low risk cast. We control these menus entirely, so we know they're GeckoMenuItems
String or IDL/UUID changes made by this patch: none

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a05f8bb2e876

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0b836bae4fd2

Comment 8

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in builds:
Firefox for Android 32.0a2 (2014-07-03)
Firefox for Android 33.0a1 (2014-07-03)

Device:
Samsung Galaxy R (Android 2.3.4)