1014239 - [boku] Show an appropriate error message when using SERVICE_ID with status = Pending

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Payments/Refunds, defect, P4)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Load https://payments-alt.allizom.org/developers/app/test-app-98hk/payments/
2. Click on 'Add, manage or view transactions for your payment accounts'
3. Click on 'Add new Boku Account'
4. Enter an Account name
5. Enter a SERVICE ID with pending status (205735a57285eb4f0cf63362)
6. Save changes

expected  behavior:
If pending SERVICE IDs are not allowed, we show a meaningful error message.

observed behavior:
#6 results in a 500

sentry: http://sentry.dmz.phx1.mozilla.com/marketplace-payments-alt/payments-alt-solitudeallizomorg/group/19424/

screenshot:  https://www.dropbox.com/s/ypvusx3d3xt6ucr/Screenshot%202014-05-21%2013.59.21.png

Comment 1

[Andy McKay]

In theory, we'll just show account is not valid. We don't actually get a message back from Boku that it's pending or anything so I'd rather not infer that. We just get an error.

https://github.com/mozilla/solitude/pull/253

Comment 2

[Kumar McMillan [:kumar]]

This was preventing devhub from verifying any service ID on payments-alt.

API Error: 31 Invalid Or Missing Price
http://sentry.dmz.phx1.mozilla.com/marketplace-payments-alt/payments-alt-solitudeallizomorg/group/19848/

reverted in https://github.com/mozilla/solitude/commit/b2ec61c8b4983629969ac1ec4e01a74302453f96