1014267 - Use the correct pref to check the system app manifest url in ContentParent.cpp

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Runtime, defect)

Description

[[:fabrice] Fabrice Desré]

Attachment: manifest-typo.patch

Found this typo when reviewing bug 1013094 - But we'll need that at least on tarako where bug 1013094 will not land.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I can't seem to find the bit of code in mozilla-b2g28_v1_3 : http://mxr.mozilla.org/mozilla-b2g28_v1_3/source/dom/ipc/ContentParent.cpp

I could be wrong; I think 1.3t is not affected.

Comment 2

[[:fabrice] Fabrice Desré]

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #1)
> I can't seem to find the bit of code in mozilla-b2g28_v1_3 :
> http://mxr.mozilla.org/mozilla-b2g28_v1_3/source/dom/ipc/ContentParent.cpp

You are looking at 1.3, not 1.3t. It's in at https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/file/0c3c328cff75/dom/ipc/ContentParent.cpp#l586

Comment 3

[Cervantes Yu [:cyu] [:cervantes]]

Comment on attachment 8426599 [details] [diff] [review]
manifest-typo.patch

Review of attachment 8426599 [details] [diff] [review]:
-----------------------------------------------------------------

Can we also change the variable names to better reflect their uses? parentAppURL and systemAppURL is confusing.

Comment 4

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/b2g-inbound/rev/5a46ea0b112a

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5a46ea0b112a

Comment 6

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/b2cc37cddc80