Closed
Bug 1014267
Opened 10 years ago
Closed 10 years ago
Use the correct pref to check the system app manifest url in ContentParent.cpp
Categories
(Firefox OS Graveyard :: Runtime, defect)
Tracking
(blocking-b2g:1.3T+, b2g-v1.3T fixed)
Tracking | Status | |
---|---|---|
b2g-v1.3T | --- | fixed |
People
(Reporter: fabrice, Assigned: fabrice)
References
Details
Attachments
(1 file)
1.29 KB,
patch
|
cyu
:
review+
|
Details | Diff | Splinter Review |
Found this typo when reviewing bug 1013094 - But we'll need that at least on tarako where bug 1013094 will not land.
Attachment #8426599 -
Flags: review?(cyu)
I can't seem to find the bit of code in mozilla-b2g28_v1_3 : http://mxr.mozilla.org/mozilla-b2g28_v1_3/source/dom/ipc/ContentParent.cpp I could be wrong; I think 1.3t is not affected.
blocking-b2g: --- → 1.3T?
Updated•10 years ago
|
blocking-b2g: 1.3T? → ---
Assignee | ||
Comment 2•10 years ago
|
||
(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #1) > I can't seem to find the bit of code in mozilla-b2g28_v1_3 : > http://mxr.mozilla.org/mozilla-b2g28_v1_3/source/dom/ipc/ContentParent.cpp You are looking at 1.3, not 1.3t. It's in at https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/file/0c3c328cff75/dom/ipc/ContentParent.cpp#l586
blocking-b2g: --- → 1.3T+
Comment 3•10 years ago
|
||
Comment on attachment 8426599 [details] [diff] [review] manifest-typo.patch Review of attachment 8426599 [details] [diff] [review]: ----------------------------------------------------------------- Can we also change the variable names to better reflect their uses? parentAppURL and systemAppURL is confusing.
Attachment #8426599 -
Flags: review?(cyu) → review+
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/5a46ea0b112a
https://hg.mozilla.org/mozilla-central/rev/5a46ea0b112a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S2 (23may)
Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/b2cc37cddc80
status-b2g-v1.3T:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•