Closed Bug 1014382 Opened 10 years ago Closed 8 years ago

Fallback to symbolicating with nm if addr2line fails

Categories

(Core :: Gecko Profiler, defect)

Product:
Core
Component:
Gecko Profiler
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: BenWa, Assigned: BenWa)

References

Details

(Whiteboard: [leave open])

Attachments

(2 files, 2 obsolete files)

IRC discussion
2.47 KB, text/plain
Details
part 2: modify symbolication script
43 bytes, text/x-github-pull-request
jld
: review+
Details | Review
Attached file IRC discussion — 
addr2line wont look through the symbol table so we should use nm if the debug information isn't available.
Attached patch nm-symbolicate.py (obsolete) — — Splinter Review 
Assignee: nobody → bgirard
Status: NEW → ASSIGNED

        Attachment #8426811 -
        Flags: review?(jmuizelaar)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        b2g patch (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #8426812 -
        Flags: review?(jmuizelaar)

        Attachment #8426811 -
        Flags: review?(jmuizelaar) → review+

    
    

    
  


  

        Attachment #8426811 -
        Attachment is obsolete: true

        Attachment #8427441 -
        Flags: review?(jld)

    
  

        Attachment #8426812 -
        Flags: review?(jmuizelaar) → review+

    
    

    
  
Comment on attachment 8426812 [details] [diff] [review]
b2g patch

This is really confusing. At some point I obsoleted the wrong patch. I did get review for the part that I already landed.

        Attachment #8426812 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 8427441 [details] [review]
part 2: modify symbolication script

Sorry for the delay in reviewing this.  To summarize my comment on the PR, I'm concerned about the possibility of using a stripped library even when we have an unstripped copy.  Otherwise it looks good.

        Attachment #8427441 -
        Flags: review?(jld) → review-

    
    

    
  
Comment on attachment 8427441 [details] [review]
part 2: modify symbolication script

Updated, please re-review

        Attachment #8427441 -
        Flags: review- → review?(jld)

        Attachment #8427441 -
        Flags: review?(jld) → review+

    
    

    
  
Checkin needed for part 2 to the b2g repo.
Keywords: checkin-needed
Depends on: 1047391

    
  
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: