1014382 - Fallback to symbolicating with nm if addr2line fails

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Benoit Girard (:BenWa)]

Attachment: IRC discussion

addr2line wont look through the symbol table so we should use nm if the debug information isn't available.

Comment 1

[Benoit Girard (:BenWa)]

Attachment: nm-symbolicate.py

Comment 2

[Benoit Girard (:BenWa)]

Attachment: b2g patch

Comment 3

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b26d1dee92a5

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b26d1dee92a5

Comment 5

[Benoit Girard (:BenWa)]

Attachment: part 2: modify symbolication script

Comment 6

[Benoit Girard (:BenWa)]

Comment on attachment 8426812 [details] [diff] [review]
b2g patch

This is really confusing. At some point I obsoleted the wrong patch. I did get review for the part that I already landed.

Comment 7

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Comment on attachment 8427441 [details] [review]
part 2: modify symbolication script

Sorry for the delay in reviewing this.  To summarize my comment on the PR, I'm concerned about the possibility of using a stripped library even when we have an unstripped copy.  Otherwise it looks good.

Comment 8

[Benoit Girard (:BenWa)]

Comment on attachment 8427441 [details] [review]
part 2: modify symbolication script

Updated, please re-review

Comment 9

[Benoit Girard (:BenWa)]

Checkin needed for part 2 to the b2g repo.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/B2G/commit/fbb3dcae219dfbbd1fd9b61ece60e32776a26b4a