1014417 - Support Contacts are not configured correctly for customization

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[rafael.marquez]

support_contacts_movistar.json file:
{
  "onlinesupport": {
    "title": "Mozilla Support",
    "href": "http://test.mozilla.org/support"
  },
  "callsupport1": {
    "title": "Call Support (Primary)",
    "href": "tel:[phone]"
  },
  "callsupport2": {
    "title": "Call Support (Secondary)",
    "href": "tel:[phone]"
  }
}

****Steps
1. Installing a 2.0 build on device
2. Clone the tests repository for sigle variant: https://github.com/telefonicaid/firefoxos-gaia-testsbuild.git
3. Configuring the file variant.json and support_contacts_movistar.json
4. Clone Gaia repository and select the master branch.
5. Executing the command "GAIA_DISTRIBUTION_DIR="URL"/firefoxos-gaia-testsbuild  PRODUCTION=1 make reset-gaia" to install gaia with single variant in the device
6.Complete FTE  with a SIM card with a mnc/mcc configured in the variant.json
7. Open Settings apps
8. Tap on Help 


*Expected Result
onlinesupport, callsupport1 and callsupport2 are displayed in Settings/Helps

*Actual Result
callsupport2 is not displayed in Settings/Helps only onlinesuppor and callsupport1 are displayed

Comment 1

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Hi Albert, could you help on this issue?

Comment 2

[Albert [:albert]]

Hi, yesterday I talked offline with Carmen and we suspect it isn't a problem of single variant build process, so she is going to have a look to this. However, if I finish bug 1009633 before she can have a look, I'll take this one.

Comment 3

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

I'm investigating it.

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

this is not an issue for customization per sim card because I can reproduce it with |GAIA_DISTRIBUTION_DIR=customization/ make reset-gaia|, change title.

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: 2014-05-29 11:41:06 的螢幕擷圖.png

screenshot for help panel

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

it should be an issue of settings app because support.json is copied into settings/resources/ if using |GAIA_DISTRIBUTION_DIR=customization make|.

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

EJ, can you take a look to this issue? thanks :D

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

ok took it !

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master

Arthur,

I noticed this is a CSS flaw when we are doing 2.0 refactor plan.

Please give it a check ! Thanks :)

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8430579 [details] [review]
patch on master

Thanks for catching it, r=me.

Comment 11

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all, landed on Gaia/master: a7ce376a5ffb9fd24d9c2f1b7899314495aa9baf

Comment 12

[rafael.marquez]

Verified in master(2.0) branch