1014426 - Make sure home2 marionette tests work well after bug 1003788 are landed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Comment 1

[Evan Tseng [:evanxd]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19527

Comment 2

[Evan Tseng [:evanxd]]

Comment on attachment 8426873 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19527

Hi Kevin,

Could you help to review the patch?

Thanks.

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8426873 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19527

Not sure why, but it failed =|

Comment 4

[Evan Tseng [:evanxd]]

Hi Kevin,

It is weird. It works on Travis Ruby VM.
Sorry, let me check for that.

Comment 5

[Evan Tseng [:evanxd]]

Seems to fix the issue. `NoSuchElement: (7) Unable to locate element: iframe[src*="app://home2.gaiamobile.org"]` Wait for travis light is green, and we could review the patch.

Comment 6

[Evan Tseng [:evanxd]]

Comment on attachment 8426873 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19527

Hi Kevin,

It is passed on Travis, see at https://travis-ci.org/mozilla-b2g/gaia/jobs/26017317#L2968.
But one test of Contacts app is failed(https://travis-ci.org/mozilla-b2g/gaia/jobs/26017317#L3359), I will file a bug to for that, and disable the test.


Could you help to review the patch?

Thanks.

Comment 7

[Kevin Grandon :kgrandon]

Evan - I think I am fine with this, but I would like to understand exactly why switchToApp(url) will no longer be supported. I'm still confused as to what's going on, and it seems like we use this method all over gaia. Could you give me the 1-paragraph reason as to why we need it, and what's changing that would cause us to need it? Thanks!

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8426873 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19527

Please flag me after providing info. Thanks!

Comment 9

[Evan Tseng [:evanxd]]

Hi Kevin,

Does the info of http://bugzil.la/1003795#c8 make sense for you?

Comment 10

[Evan Tseng [:evanxd]]

After we have the updated `switchToApp` method, we could not use the `switchToApp` method to switch to homescreen frame when the homescreen is not displayed on the screen(`transition-state="closed"). Because `switchToApp` always waits for the `transition-state` of the frame is `opened`.

In the home2 case, we could not use `switchToApp` there because https://github.com/mozilla-b2g/gaia/blob/master/dev_apps/home2/test/marionette/bookmark_test.js#L50 makes Browser app show on the screen, and the home2's `transition-state` keeps as `closed`.

Comment 11

[Kevin Grandon :kgrandon]

Comment on attachment 8426873 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19527

(In reply to Evan Tseng [:evanxd][:愛聞插低] from comment #10)
> After we have the updated `switchToApp` method, we could not use the
> `switchToApp` method to switch to homescreen frame when the homescreen is
> not displayed on the screen(`transition-state="closed"). Because
> `switchToApp` always waits for the `transition-state` of the frame is
> `opened`.

I think I'm still confused. I guess I don't understand why we don't update switchToApp to be smarter and continue working in this case.

Gareth - does this make sense to you? I guess I'm ok landing this, but I feel like the real solution is that we should make switchToApp() continue working.

Comment 12

[Evan Tseng [:evanxd]]

Hi Kevin,

If you're OK landing this, how about landing the patch now?

This bug blocks Bug 950673 and Bug 1003788. We need to land these two bug to skip more new intermittent failing tests into gaia code base.

Thanks.

Comment 13

[Evan Tseng [:evanxd]]

We're fix the failing tests once Bug 950673 and Bug 1003788 are landed. Currently, we have only last two tests need to be fixed. For skipping more failing tests, I would like to land the system app and marionette-apps changes as soon as possible.

Comment 14

[Kevin Grandon :kgrandon]

Comment on attachment 8426873 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19527

I still disagree that this is the right approach and that the system updates/test framework updates should be transparent to these APIs. (I bet there will still be problems landing if not).

Travis is green though and you have more context than me at this point, so let's land for now :)

Comment 15

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/784fe3902db9d7220fa4eb3fcf14bdafed7c6136

Comment 16

[Evan Tseng [:evanxd]]

Hi Kevin,

Thanks for the review.
And I think we need to refine the `marionette-apps` module after we fix these things.
Thanks again.

Comment 17

[Kevin Grandon :kgrandon]

Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.

Comment 18

[Josh Schmitt [Joshs]]

I am unable to verify this issue as this has back-end requirements.