101449 - Output for CCK Linux build generates other unnessary files

Status: VERIFIED FIXED

(CCK Graveyard :: CCK-Wizard, defect)

Description

[Jimmy Uen]

Besides the Linux tar.gz file in the output directory it contains other file
which are not required.

Comment 1

[Jimmy Uen]

update QA to myself

Comment 2

[Shruti Vasudevan]

Attachment: Patch to remove unnecessary files in CCK linux build

Comment 3

[tao]

Comment on attachment 51731 [details] [diff] [review]
Patch to remove unnecessary files in CCK linux build

+
+	if (linuxOption != "Linux")
+	{

Is this "linuxOption" or "platformOption"?

r=tao provided you verified that none of the needed files are removed.

Comment 4

[Shruti Vasudevan]

Marking fixed.

Comment 5

[Jimmy Uen]

Yes, the fix removed the files in output directory; setup.exe, autorun.inf, 
install.txt and launch.ini, but these files exist only when the Autorun CD 
option is checked. If this option is unchecked, the output directory will have 
all the xpi files, n6setup.exe, ..etc.
Do we want to consider to remove those too?

Comment 6

[Shruti Vasudevan]

We must remove the n6setup.exe file, but we might want to retain the xpi files.

Comment 7

[Jimmy Uen]

Reopen bug to remove n6setup.exe file

Comment 8

[Shruti Vasudevan]

Attachment: Patch to remove n6setup.exe file

Comment 9

[Shruti Vasudevan]

Attachment: Patch to remove n6setup.exe file

Comment 10

[bobj]

Re patch: http://bugzilla.mozilla.org/showattachment.cgi?attach_id=53331

In the diff, the remaining lines (not minused) between the 2 new lines (+) do
not appear to be indented:

+
{
	invisible();
 	
 	dlg->SetWindowText("         Customization is in Progress \n        
||||||||||||||||||||||||||||||||||||");
 
 	AddThirdParty();
 
 	dlg->SetWindowText("         Customization is in Progress \n        
|||||||||||||||||||||||||||||||||||||||||||||");
 
 	ReplaceINIFile();
 	
-
if (linuxOption == "Linux")
-
{
-
	dlg->SetWindowText("         Customization is in Progress \n        
|||||||||||||||||||||||||||||||||||||||||||||||");
-
	CreateLinuxInstaller();
-
}
-

 	dlg->SetWindowText("         Customization is in Progress \n        
||||||||||||||||||||||||||||||||||||||||||||||||||||||");
-
+
}


Assuming that this is a problem with the diff and that the indentation
in the real file looks OK, r=bobj 

Comment 11

[Shruti Vasudevan]

This is because I have submitted the patch using "-wb" option for diff, so tabs 
and space changes don't appear as '+'. The indentation in the original file is 
fine. 

Comment 12

[Shruti Vasudevan]

Marking fixed.

Comment 13

[Jimmy Uen]

Verified with CCK Build 2001-10-15-08.