1014503 - running devtools tests via mochitest-browser gives unhelpful error message

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Frederik Braun [:freddy]]

Running a devtools test via mochitest-browser (instead of mochitest-devtools) fails to work and the error message is horrible.

e.g.
> ./mach mochitest-browser browser/devtools/webconsole/test/browser_webconsole_bug_1010953_cspro.js ^C


The error I get is:
> TEST-UNEXPECTED-FAIL | (browser-test.js) | No tests to run. Did you pass an invalid --test-path?

Comment 1

[(not currently active) Ted Mielczarek]

Unexpected fallout of the devtools split. I think if you pass a single test we should probably ignore subsuite.

Comment 2

[Joel Maher ( :jmaher ) (UTC -0800)]

yeah, this should be easy to fix.  good find.

Comment 3

[Joel Maher ( :jmaher ) (UTC -0800)]

Attachment: ignore subsuite logic if we pass in a test-path pointing to a file (1.0)

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 8427010 [details] [diff] [review]
ignore subsuite logic if we pass in a test-path pointing to a file (1.0)

Review of attachment 8427010 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mochitest/runtests.py
@@ +481,5 @@
>          info[k] = v
>  
>        # Bug 883858 - return all tests including disabled tests
> +      testPath = self.getTestPath(options)
> +      cleanedTestPath = os.path.realpath(os.path.join(SCRIPT_DIR, self.getTestFlavor(options).replace('-chrome', ''), testPath))

This feels a little too magical to me. Is it possible to just simplify this to something like "testPath.endswith('.html') or (isBrowserChrome and testPath.endswith('.js'))'?

Comment 5

[Joel Maher ( :jmaher ) (UTC -0800)]

Attachment: ignore subsuite and skip-if for a single test case (2.0)

this should also fix bug 1017676

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 8431085 [details] [diff] [review]
ignore subsuite and skip-if for a single test case (2.0)

Review of attachment 8431085 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 7

[Joel Maher ( :jmaher ) (UTC -0800)]

inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a00dde01343

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1a00dde01343