1014517 - [Single Variant] The customization process is not executed after completing the FTE with a not configured Sim

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[rafael.marquez]

Operators configuraration in variant.json:

"operators": [
    {
      "id": "movistar",
      "mcc-mnc": [
        "214-001",
        "214-002",
        "214-005",
        "214-007"
      ],
      "apps": [
        {
          "id": "Calculator",
          "screen": 1,
          "location": 2
        },
        {
          "id": "Wikipedia",
          "screen": 2,
          "location": 0
        },
        {
          "id": "operatorResourcesLatam",
          "screen": 2,
          "location": 1
        }        
      ],
      "support_contacts": "resources/support_contacts_movistar.json",
      "default_contacts": "resources/contacts_movistar.json",
      "ringtone": {
        "path": "resources/Movistar_Mid_ABR_128kbps.ogg",
        "name": "Tono Movistar"
      },
      "wallpaper": "resources/customize2.png",
      "power": {
        "poweron": {
          "video": "resources/Power_on_test.mp4"
        },
        "poweroff": {
          "image": "resources/Power_off_test.png"
        }
      },
      "keyboard": "resources/keyboard_movistar.json",
      "network_type": "resources/network_type_movistar.json",
      "known_networks": "resources/known_networks_movistar.json",
      "data_ftu": true,
      "nfc": "resources/nfc_movistar.json",
      "sms": "resources/sms_movistar.json"
    }
  ]

SIM configured: mnc/mcc 214/007
SIM not configured: mnc/mcc 734/004

*Procedure
1. Complete the FTE whith a not configured sim card inserted
The customization process is not executed
2. Turn off the the device
3. Insert a configured sim card
4. Turn on the device
5. Open contacs app

*Expected Result
The customization process is not executed, the first time which a configured SIM is inserted

*Actual Result
The customization process is not executed after completing the FTE with a not configured Sim

Comment 1

[rafael.marquez]

*Expected Result
The customization process is executed, the first time which a configured SIM is inserted

Comment 2

[Jason Smith [:jsmith]]

This was working during the recent 1.4 test run, so this is a regression from 1.4 --> 2.0.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Please assign people of systemsfe team to look into this, thanks.

Comment 4

[Gregor Wagner [:gwagner]]

Marce, any idea what could have caused this?

Comment 5

[Marcelino Veiga Tuimil [:sonmarce]]

Not sure sure at this moment, we have to investigate it a bit more, anyway it was in our radar and we will try to fix it as soon as possible

Comment 6

[Carmen Jimenez Cabezas]

Attachment: V1 proposed patch - gecko

Comment 7

[Carmen Jimenez Cabezas]

Attachment: V1 Proposed patch - gaia

Comment 8

[Carmen Jimenez Cabezas]

r? Francisco for the FTU modifications, r? Kevin for the vertical homescreen parts

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8440426 [details] [review]
V1 Proposed patch - gaia

Homescreen part looks fine to me.

Comment 10

[Fernando Campo (:fcampo)]

Comment on attachment 8440426 [details] [review]
V1 Proposed patch - gaia

Code looks good, including tests. Seems it needs a rebase though, please ask for r? when it's done

Comment 11

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8440423 [details] [diff] [review]
V1  proposed patch - gecko

Review of attachment 8440423 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Carmen!

I would really appreciate a few more comments in this file. All this JSON file management gets a bit complicated for unfamiliar eyes, so it would be great to have a few comments about it and an example of the expected JSON as a comment in the code itself.

Also, file a follow up bug to add a test for this case to https://mxr.mozilla.org/mozilla-central/source/dom/apps/tests/test_operator_app_install.js please :)

::: dom/apps/src/OperatorApps.jsm
@@ +337,5 @@
> +      } else {
> +        debug("First Run with configured SIM ");
> +        aIdsApp = aIdsApp[key];
> +      }
> +

if (!Array.isArray(aIdsApp)) {
  aIdsApp = [aIdsApp];
}

Comment 12

[Carmen Jimenez Cabezas]

Attachment: V2 proposed patch - gecko

Comment 13

[Carmen Jimenez Cabezas]

With travis green
https://github.com/mozilla-b2g/gaia/commit/82e957160ca017087bd374cd051339e55b641e68

Comment 14

[Carmen Jimenez Cabezas]

Try looks good
https://tbpl.mozilla.org/?tree=Try&rev=cb0dd6fcf486

Comment 15

[Carmen Jimenez Cabezas]

Requesting check in for the gecko patch

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/f818c8089b45

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f818c8089b45

Comment 18

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/23e06c3624309db22ad9cb736d89700768b42b36

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d51a335b7c2d

Comment 20

[rafael.marquez]

Verified in 2.0 branch