Closed Bug 1014517 Opened 5 years ago Closed 5 years ago

[Single Variant] The customization process is not executed after completing the FTE with a not configured Sim

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

Other
Other
defect
Not set

Tracking

(blocking-b2g:2.0+, firefox31 wontfix, firefox32 fixed, firefox33 fixed, b2g-v2.0 fixed, b2g-v2.1 fixed)

VERIFIED FIXED
2.0 S4 (20june)
blocking-b2g 2.0+
Tracking Status
firefox31 --- wontfix
firefox32 --- fixed
firefox33 --- fixed
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: rafael.marquez, Assigned: macajc)

References

Details

(Keywords: regression, Whiteboard: [systemsfe])

Attachments

(2 files, 1 obsolete file)

Operators configuraration in variant.json:

"operators": [
    {
      "id": "movistar",
      "mcc-mnc": [
        "214-001",
        "214-002",
        "214-005",
        "214-007"
      ],
      "apps": [
        {
          "id": "Calculator",
          "screen": 1,
          "location": 2
        },
        {
          "id": "Wikipedia",
          "screen": 2,
          "location": 0
        },
        {
          "id": "operatorResourcesLatam",
          "screen": 2,
          "location": 1
        }        
      ],
      "support_contacts": "resources/support_contacts_movistar.json",
      "default_contacts": "resources/contacts_movistar.json",
      "ringtone": {
        "path": "resources/Movistar_Mid_ABR_128kbps.ogg",
        "name": "Tono Movistar"
      },
      "wallpaper": "resources/customize2.png",
      "power": {
        "poweron": {
          "video": "resources/Power_on_test.mp4"
        },
        "poweroff": {
          "image": "resources/Power_off_test.png"
        }
      },
      "keyboard": "resources/keyboard_movistar.json",
      "network_type": "resources/network_type_movistar.json",
      "known_networks": "resources/known_networks_movistar.json",
      "data_ftu": true,
      "nfc": "resources/nfc_movistar.json",
      "sms": "resources/sms_movistar.json"
    }
  ]

SIM configured: mnc/mcc 214/007
SIM not configured: mnc/mcc 734/004

*Procedure
1. Complete the FTE whith a not configured sim card inserted
The customization process is not executed
2. Turn off the the device
3. Insert a configured sim card
4. Turn on the device
5. Open contacs app

*Expected Result
The customization process is not executed, the first time which a configured SIM is inserted

*Actual Result
The customization process is not executed after completing the FTE with a not configured Sim
*Expected Result
The customization process is executed, the first time which a configured SIM is inserted
Whiteboard: [systemsfe]
Keywords: regression
This was working during the recent 1.4 test run, so this is a regression from 1.4 --> 2.0.
blocking-b2g: --- → 2.0?
blocking-b2g: 2.0? → 2.0+
Target Milestone: --- → 2.0 S3 (6june)
Please assign people of systemsfe team to look into this, thanks.
Flags: needinfo?(cserran)
Marce, any idea what could have caused this?
Flags: needinfo?(marce)
Not sure sure at this moment, we have to investigate it a bit more, anyway it was in our radar and we will try to fix it as soon as possible
Flags: needinfo?(marce)
Assignee: nobody → cjc
Flags: needinfo?(cserran)
Target Milestone: 2.0 S3 (6june) → 2.0 S4 (20june)
Attached patch V1 proposed patch - gecko (obsolete) — Splinter Review
Attachment #8440423 - Flags: review?(fabrice)
Attachment #8440423 - Flags: review?(fabrice) → review?(ferjmoreno)
Attachment #8440426 - Flags: review?(kgrandon)
Attachment #8440426 - Flags: review?(francisco)
r? Francisco for the FTU modifications, r? Kevin for the vertical homescreen parts
Comment on attachment 8440426 [details] [review]
V1 Proposed patch - gaia

Homescreen part looks fine to me.
Attachment #8440426 - Flags: review?(kgrandon) → review+
Attachment #8440426 - Flags: review?(francisco) → review?(fernando.campo)
Comment on attachment 8440426 [details] [review]
V1 Proposed patch - gaia

Code looks good, including tests. Seems it needs a rebase though, please ask for r? when it's done
Attachment #8440426 - Flags: review?(fernando.campo)
Attachment #8440423 - Attachment is patch: true
Comment on attachment 8440423 [details] [diff] [review]
V1  proposed patch - gecko

Review of attachment 8440423 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Carmen!

I would really appreciate a few more comments in this file. All this JSON file management gets a bit complicated for unfamiliar eyes, so it would be great to have a few comments about it and an example of the expected JSON as a comment in the code itself.

Also, file a follow up bug to add a test for this case to https://mxr.mozilla.org/mozilla-central/source/dom/apps/tests/test_operator_app_install.js please :)

::: dom/apps/src/OperatorApps.jsm
@@ +337,5 @@
> +      } else {
> +        debug("First Run with configured SIM ");
> +        aIdsApp = aIdsApp[key];
> +      }
> +

if (!Array.isArray(aIdsApp)) {
  aIdsApp = [aIdsApp];
}
Attachment #8440423 - Flags: review?(ferjmoreno) → review+
Attachment #8440423 - Attachment is obsolete: true
Keywords: checkin-needed
Requesting check in for the gecko patch
https://hg.mozilla.org/mozilla-central/rev/f818c8089b45
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Verified in 2.0 branch
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.