1014520 - User matching should have option to only offer enabled users

Status: RESOLVED WORKSFORME

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[John Elion]

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; WOW64; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; InfoPath.2; .NET4.0C; .NET4.0E; .NET CLR 1.1.4322)

Steps to reproduce:

While editting the "Assigned To" field within a bug, user entered a string "mac" which should have matched a single "active" user.


Actual results:

User was offered a menu which included the active user and several disabled users.


Expected results:

User should have been asked to confirm match to the single active user.

Comment 1

[John Elion]

I don't pretend to think this is an easy or trivial feature suggestion.

This was requested by a user in my installation.  I do not expect the bug to be implemented exactly as described, but post this to allow the discussion to proceed.

I think whether users match disabled users should be an optional setting, as I imagine that possibly not all installations use disabled users to mean only "users no longer with the company."  Also, it probably needs to be possible to still set a user to a disabled user even when this sort of option is enabled; so there might need to be a confirmation screen when a match is ONLY to a disabled user; and the menu screen may need to offer a "show disabled users" checkbox to open the search to ALL users, when the "only show enabled users" option is in force.

Comment 2

[Simon Green]

This is one of those bugs where you have to do what works for the majority of sites. I think changing the auto complete to show on enabled users is the right thing to do. This doesn't prevent a user from manually entering a disabled user in the field.

(FWIW, brc does disable users that are active but cannot log in, but we don't have user autocomplete enabled :)

This will require a change to the User.get API call to pass the status of the user: all, enabled or disabled. 'all' will be the default to match the current implementation.

  -- simon

Comment 3

[Frédéric Buclin]

User.match already skips disabled accounts by default. Tested with 4.4.4 and 4.5.4.