1014526 - Show appropriate toast for opening a new private tab

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[u421692]

Long tap on an entry from about:home and choose to open in private tab.

Actual result:
"New tab opened" notification is displayed

Expected result:
"New private tab opened" notification should be displayed(this is the current behaviour when opening a link in a new private tab from a web page)

Comment 1

[Aaron Train [:aaronmt]]

Attachment: openprivatetabtoast.patch

Comment 2

[:Margaret Leibovic]

Comment on attachment 8427027 [details] [diff] [review]
openprivatetabtoast.patch

Review of attachment 8427027 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch. I just have some style nits.

::: mobile/android/base/home/HomeFragment.java
@@ +187,5 @@
>              // a special URI until we can get a valid URL. If the url is a user-entered url, decode the URL before loading it.
>              Tabs.getInstance().loadUrl(decodeUserEnteredUrl(url), flags);
> +
> +            if (item.getItemId() == R.id.home_open_private_tab) {
> +                Toast.makeText(context, R.string.new_private_tab_opened, Toast.LENGTH_SHORT).show();   

Nit: remove trailing whitespace.

@@ +189,5 @@
> +
> +            if (item.getItemId() == R.id.home_open_private_tab) {
> +                Toast.makeText(context, R.string.new_private_tab_opened, Toast.LENGTH_SHORT).show();   
> +            }
> +            else {

Nit: Put the else on on the same line as the close brace.

Comment 3

[Aaron Train [:aaronmt]]

Attachment: openprivatetabtoast (v2 w/nits).patch

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Sorry Aaron. Bug 997288 landed with a fix for this.

https://hg.mozilla.org/integration/fx-team/rev/c87fe78a40b8

I am WONTFIX'ing so we don't get into merge issues.

Comment 5

[Aaron Train [:aaronmt]]

Can I still be a friend of the tree?

Comment 6

[:Margaret Leibovic]

(In reply to Aaron Train [:aaronmt] from comment #5)
> Can I still be a friend of the tree?

Haha, you were just in it for the badge! :)