Closed Bug 1014626 Opened 6 years ago Closed 6 years ago

Win64 "media\libstagefright\ports\win32\include\netinet/in.h(36) : fatal error C1189: #error : Unsupported architecture" build bustage

Categories

(Core :: Audio/Video, defect)

x86_64
Windows 8.1
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: RyanVM, Assigned: ajones)

References

Details

Attachments

(1 file, 2 obsolete files)

This is bustage from bug 908503.

https://tbpl.mozilla.org/php/getParsedLog.php?id=40185949&tree=Mozilla-Central

WINNT 6.1 x86-64 mozilla-central build on 2014-05-22 06:22:33 PDT for push 48ef1c52dece
slave: w64-ix-slave90

Unified_c_media_libstagefright0.c
c:\builds\moz2_slave\m-cen-w64-00000000000000000000\build\media\libstagefright\system/core/liblog/logd_write.c(104) : warning C4267: 'function' : conversion from 'size_t' to 'int', possible loss of data
c:\builds\moz2_slave\m-cen-w64-00000000000000000000\build\media\libstagefright\ports\win32\include\netinet/in.h(36) : fatal error C1189: #error :  Unsupported architecture

c:/builds/moz2_slave/m-cen-w64-00000000000000000000/build/config/rules.mk:969: recipe for target 'Unified_c_media_libstagefright0.obj' failed
Assignee: nobody → ajones
The patch here contains nothing. The actual patch ended up folded in the one for bug 1014814 in the try build (but the patch attached to bugzilla is fine)
Comment on attachment 8427585 [details] [diff] [review]
Fix Windows 64 build break

(If these people are targeting Windows why aren't they using the _byteswap_* intrinsics?)
Attached patch Fix Windows 64 build break (obsolete) — Splinter Review
Attachment #8428421 - Flags: review?(cpearce)
Attachment #8427585 - Attachment is obsolete: true
Attachment #8428421 - Attachment is obsolete: true
Attachment #8428421 - Flags: review?(cpearce)
Attachment #8428422 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/ceac4ecc8b04
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.