1014626 - Win64 "media\libstagefright\ports\win32\include\netinet/in.h(36) : fatal error C1189: #error : Unsupported architecture" build bustage

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

This is bustage from bug 908503.

https://tbpl.mozilla.org/php/getParsedLog.php?id=40185949&tree=Mozilla-Central

WINNT 6.1 x86-64 mozilla-central build on 2014-05-22 06:22:33 PDT for push 48ef1c52dece
slave: w64-ix-slave90

Unified_c_media_libstagefright0.c
c:\builds\moz2_slave\m-cen-w64-00000000000000000000\build\media\libstagefright\system/core/liblog/logd_write.c(104) : warning C4267: 'function' : conversion from 'size_t' to 'int', possible loss of data
c:\builds\moz2_slave\m-cen-w64-00000000000000000000\build\media\libstagefright\ports\win32\include\netinet/in.h(36) : fatal error C1189: #error :  Unsupported architecture

c:/builds/moz2_slave/m-cen-w64-00000000000000000000/build/config/rules.mk:969: recipe for target 'Unified_c_media_libstagefright0.obj' failed

Comment 1

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Fix Windows 64 build break

Comment 2

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

https://tbpl.mozilla.org/?tree=Try&rev=25550814738c

Comment 3

[Mike Hommey [:glandium]]

The patch here contains nothing. The actual patch ended up folded in the one for bug 1014814 in the try build (but the patch attached to bugzilla is fine)

Comment 4

[[e-mail]]

Comment on attachment 8427585 [details] [diff] [review]
Fix Windows 64 build break

(If these people are targeting Windows why aren't they using the _byteswap_* intrinsics?)

Comment 5

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Fix Windows 64 build break

Comment 6

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Fix Windows 64 build break

Comment 7

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ceac4ecc8b04

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ceac4ecc8b04