1014648 - Loading /firefox/desktop/tips/#bookmarks should not scroll down the page

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Alex Gibson [:agibson]]

Attachment: tips-screenshot.jpg

STR: Visit http://www.mozilla.org/en-US/firefox/desktop/tips/#bookmarks

The page shows the correct tab, but jumps half way down the page to the anchor so you don't see the heading or navigation. (see attached screenshot)

Expected results:

The page should load the correct tab, but stay at the top of the page.

Comment 1

[Alex Gibson [:agibson]]

I still have some tidying up to do, but this change is now up on demo5 for testing/viewing:

https://www-demo5.allizom.org/en-US/firefox/desktop/tips/

Comment 2

[Jennifer Bertsch [:jbertsch]]

Thanks, Alex.

Holly, Jean, and I all tested and it is working as expected.  Can we push this fix live on Friday, Mike?

Comment 3

[Mike Alexis [:malexis]]

(In reply to Jennifer Bertsch [:jbertsch] from comment #2)
> Thanks, Alex.
> 
> Holly, Jean, and I all tested and it is working as expected.  Can we push
> this fix live on Friday, Mike?

Yes, we'll target Friday.

Alex, can you submit a PR when ready?

Comment 4

[Alex Gibson [:agibson]]

Sure thing, I'll have a PR ready first thing, thanks

Comment 5

[Alex Gibson [:agibson]]

Attachment: GitHub pull request

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/44bb1731fcc366bd005fe1d3069cf9c817211dd1
[fix bug 1014648] Loading /firefox/desktop/tips/ with a hash should not scroll the page

https://github.com/mozilla/bedrock/commit/61b728a148a5ae1438364c819108f265a8251ccf
Merge pull request #2042 from mozilla/bug-1014648-tips-page-hash-scroll

[fix bug 1014648] Loading /firefox/desktop/tips/ with a hash should not scroll the page

Comment 7

[Alex Gibson [:agibson]]

On prod: https://www.mozilla.org/en-US/firefox/desktop/tips/#bookmarks

Comment 8

[Jean Collings]

Thank you all!

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/fb5ded8f4c5eae8d21e7f6460f496a63a6f396e8
[bug 1014648] Add hashchange support to firefox tips page

https://github.com/mozilla/bedrock/commit/e34807170a5e9a3d4624efe929baea68f54ce118
Merge pull request #2046 from alexgibson/bug-1014648-hashchange-support-firefox-tips-page

[bug 1014648] Add hashchange support to firefox tips page