1014663 - [B2G][Tarako][Lockscreen][Camera] Cannot exit lockscreen camera when passcode lock is enabled

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Logcat

Description:
With passcode lock enabled, user cannot close lockscreen camera with home button. User must power off device to exit camera screen.

Repro Steps:
1) Update a Tarako to BuildID: 20140522014001
2) Enable Passcode lock in lockscreen settings
3) Lock screen by short pressing power button
4) Short press power button and open camera from lockscreen
5) Take picture then press home button

Actual:
User cannot exit lockscreen camera.

Expected:
User can use home button to exit lockscreen camera.

1.3T Environmental Variables:
Device: Tarako 1.3T MOZ
BuildID: 20140522014001
Gaia: 6ad553e9db091f7400069a4551941cf4249c0544
Gecko: d95a3af17d6e
Version: 28.1
Firmware Version: sp6821a-Gonk4.0-5-12

Notes:
Repro frequency: 3/3, 100%
See attached: Youtube video clip & logcat

Comment 1

[Brogan Zumwalt [Inactive]]

Youtube video link: http://youtu.be/Lly-JUO9BZo

Comment 2

[Brogan Zumwalt [Inactive]]

Issue does NOT occur on latest 1.3 Buri. User can use home button to exit lockscreen camera.

Environmental Variables:
Device: Buri v1.3 Mozilla RIL
BuildID: 20140522024002
Gaia: 0ce948e378cab7ed3db20231281dd7ca2eb99779
Gecko: a61b65a57289
Version: 28.0
Firmware Version: v1.2-device.cfg

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

bad 449e0cd70ed999ffc4ae9e6152d57ab01193376d
good 7af70c86a633d77cefc4e1b859e42d36df1d6320

Anthony, would you be able to take a look please?

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

correction on the regression range : 

ckreinbring found: 
No repro: 20140521041221
7d879b1f038fb2ef1bb2f42476e1554e96cdfd2f (ae0d498d2659)
Repro:    20140521052317
4fd33d0264882f43920016acab774f0e56a6c5d8 (0c3c328cff75)

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Flagging rik too coz the regression was bug 1011418.

Comment 6

[Mike Habicher [:mikeh] (high bugzilla latency)]

Seeing something similar with the emergency call screen in bug 1016616.

Comment 7

[Joe Cheng [:jcheng] (please needinfo)]

Greg, do you mind providing some update on this? thanks

Comment 8

[Greg Weng [:snowmantw][:gweng][:λ]]

Will bisect to make sure it's regression (according to the comments) or not later.
Today I was occupied by the LockScreen as-an-app timeout issue again, sorry for that.

Comment 9

[David Flanagan [:djf]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #5)
> Flagging rik too coz the regression was bug 1011418.

Tim: that looks like an unrelated bug. Did you type the wrong number?

Comment 10

[David Flanagan [:djf]]

Ah, I see that Tim meant bug 1010418.  And I notice that when pressing the home button when in the lockscreen camera I get this error message:

[JavaScript Error: "TypeError: this.enableWithoutCover is not a function" {file:   "app://system.gaiamobile.org/js/lockscreen.js" line: 446}]

That should make it easy to fix.

Comment 11

[David Flanagan [:djf]]

Okay, this is kind of confusing.

The regression range identified bug 1010418 as the cause of this bug. That bug was fixed by backing out bug 982530 which was a workaround that was no longer needed. So far, this is fine.

But bug 989729 was built on top of 982530.  It added a call to enableWithoutCover(), which is one of the functions that has been backed out.

The result is that when we launch the camera from a locked lockscreen, pressing the home button throws a TypeError before it can actually return to the lockscreen.

Bug 989729 didn't do anything else other than add that enableWithoutCover() call, so I think we can fix this bug just by backing that one out.  I'll attach a patch.

Comment 12

[David Flanagan [:djf]]

Attachment: back out bug 989729

Greg,

If this looks good to you, please go ahead and land it

Comment 13

[David Flanagan [:djf]]

I've tested the attached patch and it works for me. Greg was the author of the patch that is being backed out, so hopefully he can say whether there will be other side effects cause by this backout.

Comment 14

[David Flanagan [:djf]]

Removing the two "see also" bugs since neither of those are 1.3T and neither one seems to have the distinctive error message in the logcat.

Comment 15

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8431209 [details] [review]
back out bug 989729

Hi David: thanks for your help to figure out the confusing regression state, and the patch looks good for me. It also passed all tests except the 3 marionette tests which now failed at all v1.3t PR.

Comment 16

[Greg Weng [:snowmantw][:gweng][:λ]]

v1.3t: https://github.com/mozilla-b2g/gaia/commit/c196663908b955ededc85a42e50dbade690017d5

Comment 17

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to David Flanagan [:djf] from comment #9)
> (In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from
> comment #5)
> > Flagging rik too coz the regression was bug 1011418.
> 
> Tim: that looks like an unrelated bug. Did you type the wrong number?

Yes, I was meant to type bug 1010418.

Comment 18

[Josh Schmitt [Joshs]]

Issue has been verified fixed for 1.3t, the user can exit the Camera when launched from the homescreen

Environmental Variables:
Device: Tarako
Build ID: 20140530014002
Gaia: e68858693b71d917c9c5ee7e215f7ceea04635f7
Gecko: 1945abae19ff
Version: 28.1 (1.3) 
Firmware Version: SP6821a-Gonk-4.0-5-12

Comment 19

[Josh Schmitt [Joshs]]

Correction to previous comment, 

the user can exit the Camera when launched from the lockscreen

Comment 20

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

note : bug 989729 is still fixed.  ie I can unlock the screen after getting a call from the lockscreen.