1014691 - Move TestAsyncPanZoomController into gfx/layers/apz/test

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Botond Ballo [:botond]]

TestAsyncPanZoomController is an APZ-related file that did not get moved into gfx/layers/apz when that folder was created. We should move it there.

There is a 'test' subdirectory in gfx/layers/apz, which currently contains the only mochitest so far using the bug 961289 framework. We may want to create 'gtest' and 'mochitest' subdirectories under 'test' to keep the two types of tests separate.

Comment 1

[Botond Ballo [:botond]]

I'd like to do this, in preparation for splitting TestAsyncPanZoomController.cpp up into several files, because at 3000+ lines, it's getting a bit unwieldy to work with.

I have patches that make the move building locally. Try push:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7cbc6a287e96

Comment 2

[Botond Ballo [:botond]]

Looks good, posting for review. Kats, if you think the moz.build changes warrant additional review from a build peer, please feel free to flag accordingly.

Comment 3

[Botond Ballo [:botond]]

Attachment: MozReview Request: Bug 1014691 - Move APZ mochitests to gfx/layers/apz/test/mochitest. r=kats

Bug 1014691 - Move APZ mochitests to gfx/layers/apz/test/mochitest. r=kats

Comment 4

[Botond Ballo [:botond]]

Attachment: MozReview Request: Bug 1014691 - Fix an include-what-you-use error in TestCompositor.cpp. r=kats

Bug 1014691 - Fix an include-what-you-use error in TestCompositor.cpp. r=kats

Comment 5

[Botond Ballo [:botond]]

Attachment: MozReview Request: Bug 1014691 - Move TestAsyncPanZoomController.cpp to gfx/layers/apz/test/gtest. r=kats,glandium

Bug 1014691 - Move TestAsyncPanZoomController.cpp to gfx/layers/apz/test/gtest. r=kats

Comment 6

[Botond Ballo [:botond]]

Attachment: MozReview Request: Bug 1014691 - Get TestAsyncPanZoomController to compile in its new location. r=kats

Bug 1014691 - Get TestAsyncPanZoomController to compile in its new location. r=kats

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Hm, since the refests live outside the test/ folder, should we just flatten the tree a bit and have apz/mochitest, apz/gtest, and apz/reftest?

Comment 8

[Botond Ballo [:botond]]

I like the idea of moving reftests into the apz folder as well. I still think there's value in having a 'test' folder to group the various kinds of tests - any reason not to do that?

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Sure, we can do that too.

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8662167 [details]
MozReview Request: Bug 1014691 - Move APZ mochitests to gfx/layers/apz/test/mochitest. r=kats

https://reviewboard.mozilla.org/r/19549/#review17647

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8662168 [details]
MozReview Request: Bug 1014691 - Fix an include-what-you-use error in TestCompositor.cpp. r=kats

https://reviewboard.mozilla.org/r/19551/#review17649

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8662169 [details]
MozReview Request: Bug 1014691 - Move TestAsyncPanZoomController.cpp to gfx/layers/apz/test/gtest. r=kats,glandium

https://reviewboard.mozilla.org/r/19553/#review17651

MozReview shows the new moz.build file as having a lot of trailing whitespace. Other than that it looks ok to me, but needs build peer review.

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8662170 [details]
MozReview Request: Bug 1014691 - Get TestAsyncPanZoomController to compile in its new location. r=kats

https://reviewboard.mozilla.org/r/19555/#review17653

Comment 14

[Botond Ballo [:botond]]

Comment on attachment 8662169 [details]
MozReview Request: Bug 1014691 - Move TestAsyncPanZoomController.cpp to gfx/layers/apz/test/gtest. r=kats,glandium

:glandium, would you mind reviewing the build system changes?

Comment 15

[Botond Ballo [:botond]]

Comment on attachment 8662169 [details]
MozReview Request: Bug 1014691 - Move TestAsyncPanZoomController.cpp to gfx/layers/apz/test/gtest. r=kats,glandium

Bug 1014691 - Move TestAsyncPanZoomController.cpp to gfx/layers/apz/test/gtest. r=kats,glandium

Comment 16

[Botond Ballo [:botond]]

Comment on attachment 8662170 [details]
MozReview Request: Bug 1014691 - Get TestAsyncPanZoomController to compile in its new location. r=kats

Bug 1014691 - Get TestAsyncPanZoomController to compile in its new location. r=kats

Comment 17

[Botond Ballo [:botond]]

Attachment: MozReview Request: Bug 1014691 - Move APZ reftests to apz/test/reftest. r=kats

Bug 1014691 - Move APZ reftests to apz/test/reftest. r=kats

Comment 18

[Botond Ballo [:botond]]

Comment on attachment 8662169 [details]
MozReview Request: Bug 1014691 - Move TestAsyncPanZoomController.cpp to gfx/layers/apz/test/gtest. r=kats,glandium

Now with the trailing whitespace fixed. Carrying r+ from kats.

Comment 19

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8663034 [details]
MozReview Request: Bug 1014691 - Move APZ reftests to apz/test/reftest. r=kats

https://reviewboard.mozilla.org/r/19691/#review17765

Comment 20

[Mike Hommey [:glandium]]

Comment on attachment 8662169 [details]
MozReview Request: Bug 1014691 - Move TestAsyncPanZoomController.cpp to gfx/layers/apz/test/gtest. r=kats,glandium

https://reviewboard.mozilla.org/r/19553/#review17889

Comment 21

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c1e7b164b6f5
https://hg.mozilla.org/integration/mozilla-inbound/rev/a88317c76f64
https://hg.mozilla.org/integration/mozilla-inbound/rev/5807b0c3f345
https://hg.mozilla.org/integration/mozilla-inbound/rev/82e3928eea38
https://hg.mozilla.org/integration/mozilla-inbound/rev/ffbfef1d206e

Comment 22

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c1e7b164b6f5
https://hg.mozilla.org/mozilla-central/rev/a88317c76f64
https://hg.mozilla.org/mozilla-central/rev/5807b0c3f345
https://hg.mozilla.org/mozilla-central/rev/82e3928eea38
https://hg.mozilla.org/mozilla-central/rev/ffbfef1d206e