Closed Bug 1014691 Opened 5 years ago Closed 4 years ago

Move TestAsyncPanZoomController into gfx/layers/apz/test

Categories

(Core :: Panning and Zooming, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: botond, Assigned: botond)

Details

Attachments

(5 files)

TestAsyncPanZoomController is an APZ-related file that did not get moved into gfx/layers/apz when that folder was created. We should move it there.

There is a 'test' subdirectory in gfx/layers/apz, which currently contains the only mochitest so far using the bug 961289 framework. We may want to create 'gtest' and 'mochitest' subdirectories under 'test' to keep the two types of tests separate.
I'd like to do this, in preparation for splitting TestAsyncPanZoomController.cpp up into several files, because at 3000+ lines, it's getting a bit unwieldy to work with.

I have patches that make the move building locally. Try push:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7cbc6a287e96
Looks good, posting for review. Kats, if you think the moz.build changes warrant additional review from a build peer, please feel free to flag accordingly.
Bug 1014691 - Move APZ mochitests to gfx/layers/apz/test/mochitest. r=kats
Attachment #8662167 - Flags: review?(bugmail.mozilla)
Bug 1014691 - Fix an include-what-you-use error in TestCompositor.cpp. r=kats
Attachment #8662168 - Flags: review?(bugmail.mozilla)
Bug 1014691 - Move TestAsyncPanZoomController.cpp to gfx/layers/apz/test/gtest. r=kats
Attachment #8662169 - Flags: review?(bugmail.mozilla)
Bug 1014691 - Get TestAsyncPanZoomController to compile in its new location. r=kats
Attachment #8662170 - Flags: review?(bugmail.mozilla)
Assignee: nobody → botond
Hm, since the refests live outside the test/ folder, should we just flatten the tree a bit and have apz/mochitest, apz/gtest, and apz/reftest?
I like the idea of moving reftests into the apz folder as well. I still think there's value in having a 'test' folder to group the various kinds of tests - any reason not to do that?
Comment on attachment 8662167 [details]
MozReview Request: Bug 1014691 - Move APZ mochitests to gfx/layers/apz/test/mochitest. r=kats

https://reviewboard.mozilla.org/r/19549/#review17647
Attachment #8662167 - Flags: review?(bugmail.mozilla) → review+
Attachment #8662168 - Flags: review?(bugmail.mozilla) → review+
Comment on attachment 8662168 [details]
MozReview Request: Bug 1014691 - Fix an include-what-you-use error in TestCompositor.cpp. r=kats

https://reviewboard.mozilla.org/r/19551/#review17649
Comment on attachment 8662169 [details]
MozReview Request: Bug 1014691 - Move TestAsyncPanZoomController.cpp to gfx/layers/apz/test/gtest. r=kats,glandium

https://reviewboard.mozilla.org/r/19553/#review17651

MozReview shows the new moz.build file as having a lot of trailing whitespace. Other than that it looks ok to me, but needs build peer review.
Attachment #8662169 - Flags: review?(bugmail.mozilla)
Comment on attachment 8662170 [details]
MozReview Request: Bug 1014691 - Get TestAsyncPanZoomController to compile in its new location. r=kats

https://reviewboard.mozilla.org/r/19555/#review17653
Attachment #8662170 - Flags: review?(bugmail.mozilla) → review+
Comment on attachment 8662169 [details]
MozReview Request: Bug 1014691 - Move TestAsyncPanZoomController.cpp to gfx/layers/apz/test/gtest. r=kats,glandium

:glandium, would you mind reviewing the build system changes?
Attachment #8662169 - Flags: review?(mh+mozilla)
Comment on attachment 8662169 [details]
MozReview Request: Bug 1014691 - Move TestAsyncPanZoomController.cpp to gfx/layers/apz/test/gtest. r=kats,glandium

Bug 1014691 - Move TestAsyncPanZoomController.cpp to gfx/layers/apz/test/gtest. r=kats,glandium
Attachment #8662169 - Attachment description: MozReview Request: Bug 1014691 - Move TestAsyncPanZoomController.cpp to gfx/layers/apz/test/gtest. r=kats → MozReview Request: Bug 1014691 - Move TestAsyncPanZoomController.cpp to gfx/layers/apz/test/gtest. r=kats,glandium
Attachment #8662169 - Flags: review?(bugmail.mozilla)
Comment on attachment 8662170 [details]
MozReview Request: Bug 1014691 - Get TestAsyncPanZoomController to compile in its new location. r=kats

Bug 1014691 - Get TestAsyncPanZoomController to compile in its new location. r=kats
Bug 1014691 - Move APZ reftests to apz/test/reftest. r=kats
Attachment #8663034 - Flags: review?(bugmail.mozilla)
Comment on attachment 8662169 [details]
MozReview Request: Bug 1014691 - Move TestAsyncPanZoomController.cpp to gfx/layers/apz/test/gtest. r=kats,glandium

Now with the trailing whitespace fixed. Carrying r+ from kats.
Attachment #8662169 - Flags: review?(bugmail.mozilla) → review+
Comment on attachment 8663034 [details]
MozReview Request: Bug 1014691 - Move APZ reftests to apz/test/reftest. r=kats

https://reviewboard.mozilla.org/r/19691/#review17765
Attachment #8663034 - Flags: review?(bugmail.mozilla) → review+
Comment on attachment 8662169 [details]
MozReview Request: Bug 1014691 - Move TestAsyncPanZoomController.cpp to gfx/layers/apz/test/gtest. r=kats,glandium

https://reviewboard.mozilla.org/r/19553/#review17889
Attachment #8662169 - Flags: review?(mh+mozilla) → review+
You need to log in before you can comment on or make changes to this bug.