1014696 - Marketplace banner missing image

Status: RESOLVED FIXED

(Firefox Affiliates Graveyard :: affiliates.mozilla.org, defect)

Description

[Austin King [:ozten]]

New Affiliates site looks great, congrats!

The Marketplace is missing an image, until you finally select a color.

Steps to Reproduce
1) https://affiliates.mozilla.org/en-US/dashboard/ > Create a Banner
2) FirefoxOS

Actual:
Blank missing image

Expected:
Preview image of Marketplace Banner

Note this does eventually show up

3) Click Marketplace
4) Select Lang = En, size 172x60, Color black

Now there is an image

Comment 1

[Osmose [:osmose, :mkelly]]

So the cause of this bug is how we decide to show a preview: we only show previews for banners that have a 150x150 pixel variation. Since Marketplace's banner is smaller than that, it doesn't get a preview.

We originally decided upon this to deal with the problem of wanting to avoid having to make custom previews in many locales for every single banner. Automatically making previews that fit in a 150x150 box and look reasonable is hard when you have banners that are 600x125 with text on them.

A workaround that would fix the marketplace banner, along with at least 2 other banners on prod, would be to also allow banner variations smaller than 150x150 and just center them in the 150x150 box.

josorio and craigcook: As a short-term fix, do you think this is a good idea?

Comment 2

[Craig Cook (:craigcook)]

(In reply to Michael Kelly [:mkelly,:Osmose] from comment #1)
 
> A workaround that would fix the marketplace banner, along with at least 2
> other banners on prod, would be to also allow banner variations smaller than
> 150x150 and just center them in the 150x150 box.
> 
> josorio and craigcook: As a short-term fix, do you think this is a good idea?

Yeah, we show show smaller banners if that's all we have available. We might need to adjust the CSS to make sure they're centered but I think it might also "Just Work" without doing anything to the layout.

Comment 3

[Craig Cook (:craigcook)]

"we should show" ... really wish I could edit comments.

Comment 4

[Jessica Osorio [:josorio]]

In an effort to close outstanding bugs, I'm noting here that changes on the Affiliates site have been on hold since Q3 of 2014. We're working on a better solution for this program, which we're seeking to launch in Q2 of 2015. Thank you!