101471 - Implement "UNSELECTED" in config.it on Linux

Status: RESOLVED INCOMPLETE

(SeaMonkey :: Installer, enhancement)

Description

[tao]

To reproduce it:
1. Pull a 0.9.4 branch build including both the mozilla and commercial tree
2. add new component in the config.it for unix and set the attribt to "UNSELECTED".
3. run deliver.pl to produce installable build.
4. Run the resulting installer stub and go for "Customized Install Type'
5. You see the added component appeared with the check box "checked".

The expected behavior is to have the new component "un-checked".
See details in bugscape 9035.

Comment 1

[Daniel Veditz [:dveditz]]

This is another case where the windows config.ini syntax differs from the mac
and linux syntax. The absence of the SELECTED attribute is what you want,
windows changed to allow this to be explicit in the config.ini

Another one for the eventual meta bug about making the config.ini syntax more
the same XP

Comment 2

[Syd Logan]

over to curt

Comment 3

[Curt Patrick (gone)]

Dan, is there an actual meta-bug filed about sync'ing up the config.ini syntax
between platforms?  If not I'll open one.  This bug needs to be a dependency of
that meta bug.

Comment 4

[Daniel Veditz [:dveditz]]

We don't have to have this one, although it'd be nice

Comment 5

[Andrew Schultz]

the real problem here seems to be that "SELECTED" matches "UNSELECTED".  If the
parser didn't find "UNSELECTED" when it looks for "SELECTED", there wouldn't be
a problem here.

==> me

Comment 6

[Andrew Schultz]

Attachment: patch

this fixes:
1. this bug
2. leak of currInstallSizeStr, currArchiveSizeStr, currAttrStr, showDlg
3. crash when attribute key was missing.
4. bailing properly when short description entry is empty.

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 147484 [details] [diff] [review]
patch

sr=dveditz if we're still using this

Comment 8

[Robert Kaiser]

Old XPFE installer is dead now, so this is not relevant any more.