1014819 - Prepending SPS/PPS H.264 packets when missing in OMX encoder output is broken

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

The OMX H.264 encoder on Flame's tries to insert SPS/PPS before any IDR (iframe) that doesn't include them.  Unfortunately, it tries to fetch them from stagefright, which doesn't work (at least not on the Flame with JB gonk).

Attached will be a patch that drops the dependency on stagefright and works.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Replace OMX GetCodecConfig with straight caching of H.264 SPS/PPS

includes some cleanup and logging.  Depends on other patches in the queue to apply

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Replace OMX GetCodecConfig with straight caching of H.264 SPS/PPS

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Attachment: remove no-longer-needed GetCodecConfig

Comment 4

[John Lin [:jhlin][:jolin]]

Comment on attachment 8427261 [details] [diff] [review]
Replace OMX GetCodecConfig with straight caching of H.264 SPS/PPS

Review of attachment 8427261 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Having our own copy of parameter sets also saves the overhead of reading them from stagefright per I-frame.

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Green try on the mass of patches -
https://tbpl.mozilla.org/?tree=Try&rev=36fed02b8193

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/68d1416b253c
https://hg.mozilla.org/integration/mozilla-inbound/rev/e6a4624d247f

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/68d1416b253c
https://hg.mozilla.org/mozilla-central/rev/e6a4624d247f