1014988 - Use Context.MODE_ENABLE_WRITE_AHEAD_LOGGING when opening databases

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Data Providers, defect)

Description

[Richard Newman [:rnewman]]

Added in API 16:

http://developer.android.com/reference/android/content/Context.html#MODE_ENABLE_WRITE_AHEAD_LOGGING

Much better than opening the DB then issuing a query to set up WAL! Faster, and probably safer, too.

Comment 1

[Richard Newman [:rnewman]]

Attachment: Use Context.MODE_ENABLE_WRITE_AHEAD_LOGGING when opening databases. v1

This looks like the right approach.

Note that SQLiteOpenHelper encapsulates the mode flag mechanism; this API call was also added in API 16.

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8429787 [details] [diff] [review]
Use Context.MODE_ENABLE_WRITE_AHEAD_LOGGING when opening databases. v1

Brian gets review on this, 'cos empty queue.

Tested locally on a KitKat device.

Comment 3

[Brian Nicholson (:bnicholson)]

Comment on attachment 8429787 [details] [diff] [review]
Use Context.MODE_ENABLE_WRITE_AHEAD_LOGGING when opening databases. v1

Review of attachment 8429787 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/db/BrowserDatabaseHelper.java
@@ +1729,1 @@
>              db.setLockingEnabled(false);

Since you added an API level 16 check, you can move this into it since this doesn't do anything on 16+.

Comment 4

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/dc94e2a05c97

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/dc94e2a05c97