1015072 - Create <gaia-tabs> web-component

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Wilson Page [:wilsonpage]]

Migrate the existing 'Tabs' building block [1] to web-components.

[1] http://buildingfirefoxos.com/building-blocks/tabs.html

Comment 1

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8429214 [details] [review]
pull-request (master)

This is awesome! I would like to see a new patch before R+ing, but this looks really good. I made a few comments on github. Thanks!

Comment 3

[Wilson Page [:wilsonpage]]

- Improved examples
- Fixed r? comments from kgrandon
- Removed dead code

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8429214 [details] [review]
pull-request (master)

I think I'm generally happy with the current state of these. The inner click bubbling looks a bit weird to me, but we can always revisit this later. Nice work!

Comment 5

[Wilson Page [:wilsonpage]]

kgrandon: I'm using a hand-rolled delegate pattern to make sure that if tabs are added/removed, we don't have to update event listeners. We could loop over the tabs and bind a listener for each, but that wouldn't support dynamic tab insertion/removal.

Comment 6

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 8429214 [details] [review]
pull-request (master)

Looks great!
left a couple of comments in GH.

Comment 7

[Wilson Page [:wilsonpage]]

Landed on 'master' https://github.com/mozilla-b2g/gaia/commit/7e6d68b818348b545dd0e9190ac9194917e78b4f