1015128 - Textarea doesn't redraw properly when adding a newline to break a line (with RTL text in sibling element)

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect, P4)

Description

[Mats Palmgren (inactive)]

Backout the wallpaper in bug 1007067 and fix it properly.

Comment 1

[Simon Montagu :smontagu]

Mats, have you had any success in making automated tests for bugs like this? I tried in the past with mochitests using snapshotWindow, and was never able to capture the problem.

Comment 2

[Mats Palmgren (inactive)]

This was pretty straightforward to test actually.  I've attached a reftest
in bug 1007067.  But yeah, I think some invalidation bugs and such are
impossible to test with the reftest framework.  I imagine we would need to
take native screenshots to capture such bugs.

Comment 3

[Simon Montagu :smontagu]

Attachment: Patch

I want to check this doesn't regress performance before asking review (I suspect that with one fix and another we may have lost all the gains from bug 646359 by now)

Comment 4

[Simon Montagu :smontagu]

Attachment: Patch including backout

There doesn't seem to be any measurable performance regression from this

Comment 5

[Mats Palmgren (inactive)]

Comment on attachment 8436866 [details] [diff] [review]
Patch including backout

Nit: please end the sentence in the comments with a full stop.

Comment 6

[Mats Palmgren (inactive)]

(FTR: a reftest was added in bug 1007067)

Comment 7

[Simon Montagu :smontagu]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7fc2e2faeaf0
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5616a2e176c

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e5616a2e176c