Closed Bug 1015180 Opened 7 years ago Closed 7 years ago

Move link*ExitFrame to the common macro assembler.

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: nbp, Assigned: nbp)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Attachment #8427748 - Flags: review?(jdemooij)
Attachment #8427748 - Flags: feedback?(mrosenberg)
Attachment #8427748 - Flags: feedback?(branislav.rankov)
Comment on attachment 8427748 [details] [diff] [review]
Move linkExitFrame to the common MacroAssembler.

Review of attachment 8427748 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/IonMacroAssembler.cpp
@@ +903,5 @@
> +
> +// Save an exit frame to the thread data of the current thread, given a
> +// register that holds a PerThreadData *.
> +void
> +MacroAssembler::linkParallelExitFrame(Register pt) {

Nit: { on the next line.
Attachment #8427748 - Flags: review?(jdemooij) → review+
Comment on attachment 8427748 [details] [diff] [review]
Move linkExitFrame to the common MacroAssembler.

This looks good to me. All jit-tests pass on the MIPS simulator with this patch.
Attachment #8427748 - Flags: feedback?(branislav.rankov) → feedback+
Attachment #8427748 - Flags: feedback?(mrosenberg) → feedback+
https://hg.mozilla.org/mozilla-central/rev/7dc3d59d9ad2
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.