1015180 - Move link*ExitFrame to the common macro assembler.

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Comment 1

[Nicolas B. Pierron [:nbp]]

Attachment: Move linkExitFrame to the common MacroAssembler.

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8427748 [details] [diff] [review]
Move linkExitFrame to the common MacroAssembler.

Review of attachment 8427748 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/IonMacroAssembler.cpp
@@ +903,5 @@
> +
> +// Save an exit frame to the thread data of the current thread, given a
> +// register that holds a PerThreadData *.
> +void
> +MacroAssembler::linkParallelExitFrame(Register pt) {

Nit: { on the next line.

Comment 3

[Branislav Rankov [:rankov]]

Comment on attachment 8427748 [details] [diff] [review]
Move linkExitFrame to the common MacroAssembler.

This looks good to me. All jit-tests pass on the MIPS simulator with this patch.

Comment 4

[Nicolas B. Pierron [:nbp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7dc3d59d9ad2
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3f2754fcfb8 (Fix broken builds by replacing the static_assert)

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7dc3d59d9ad2