Mozbase mozrunner unit test failures on Windows 8

NEW
Unassigned

Status

defect
5 years ago
5 years ago

People

(Reporter: dminor, Unassigned)

Tracking

Trunk
All
Windows 8
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

From a recent cedar run [1], relevant portions of log:

15:24:07     INFO -  test_process_stop_via_multiple_threads (test_threads.MozrunnerThreadsTestCase)
15:24:07     INFO -  Stop the runner via multiple threads ... ProcessManager UNABLE to use job objects to manage child processes
15:24:07     INFO -  ProcessManager NOT managing child processes
15:24:12     INFO -  Exception in thread Thread-86:
15:24:12     INFO -  Traceback (most recent call last):
15:24:12     INFO -    File "c:\mozilla-build\python27\Lib\threading.py", line 551, in __bootstrap_inner
15:24:12     INFO -      self.run()
15:24:12     INFO -    File "C:\slave\test\build\tests\mozbase\mozrunner\tests\test_threads.py", line 24, in run
15:24:12     INFO -      self.runner.stop()
15:24:12     INFO -    File "C:\slave\test\build\venv\lib\site-packages\mozrunner\base.py", line 148, in stop
15:24:12     INFO -      self.process_handler.kill(sig=sig)
15:24:12     INFO -    File "C:\slave\test\build\venv\lib\site-packages\mozprocess\processhandler.py", line 688, in kill
15:24:12     INFO -      self.proc.kill(sig=sig)
15:24:12     INFO -    File "C:\slave\test\build\venv\lib\site-packages\mozprocess\processhandler.py", line 128, in kill
15:24:12     INFO -      raise OSError(err)
15:24:12     INFO -  OSError: Could not terminate process
15:24:12     INFO -  Exception in thread Thread-87:
15:24:12     INFO -  Traceback (most recent call last):
15:24:12     INFO -    File "c:\mozilla-build\python27\Lib\threading.py", line 551, in __bootstrap_inner
15:24:12     INFO -      self.run()
15:24:12     INFO -    File "C:\slave\test\build\tests\mozbase\mozrunner\tests\test_threads.py", line 24, in run
15:24:12     INFO -      self.runner.stop()
15:24:12     INFO -    File "C:\slave\test\build\venv\lib\site-packages\mozrunner\base.py", line 148, in stop
15:24:12     INFO -      self.process_handler.kill(sig=sig)
15:24:12     INFO -    File "C:\slave\test\build\venv\lib\site-packages\mozprocess\processhandler.py", line 688, in kill
15:24:12     INFO -      self.proc.kill(sig=sig)
15:24:12     INFO -    File "C:\slave\test\build\venv\lib\site-packages\mozprocess\processhandler.py", line 125, in kill
15:24:12     INFO -      winprocess.GetExitCodeProcess(self._handle)
15:24:12     INFO -    File "C:\slave\test\build\venv\lib\site-packages\mozprocess\winprocess.py", line 51, in ErrCheckBool
15:24:12     INFO -      raise WinError()
15:24:12     INFO -  WindowsError: [Error 6] The handle is invalid.
15:24:12     INFO -  Exception in thread Thread-88:
15:24:12     INFO -  Traceback (most recent call last):
15:24:12     INFO -    File "c:\mozilla-build\python27\Lib\threading.py", line 551, in __bootstrap_inner
15:24:12     INFO -      self.run()
15:24:12     INFO -    File "C:\slave\test\build\tests\mozbase\mozrunner\tests\test_threads.py", line 24, in run
15:24:12     INFO -      self.runner.stop()
15:24:12     INFO -    File "C:\slave\test\build\venv\lib\site-packages\mozrunner\base.py", line 148, in stop
15:24:12     INFO -      self.process_handler.kill(sig=sig)
15:24:12     INFO -    File "C:\slave\test\build\venv\lib\site-packages\mozprocess\processhandler.py", line 688, in kill
15:24:12     INFO -      self.proc.kill(sig=sig)
15:24:12     INFO -    File "C:\slave\test\build\venv\lib\site-packages\mozprocess\processhandler.py", line 126, in kill
15:24:12     INFO -      self._cleanup()
15:24:12     INFO -    File "C:\slave\test\build\venv\lib\site-packages\mozprocess\processhandler.py", line 529, in _cleanup
15:24:12     INFO -      self._handle.Close()
15:24:12     INFO -    File "C:\slave\test\build\venv\lib\site-packages\mozprocess\winprocess.py", line 66, in Close
15:24:12     INFO -      self.CloseHandle(self)
15:24:12     INFO -    File "C:\slave\test\build\venv\lib\site-packages\mozprocess\winprocess.py", line 51, in ErrCheckBool
15:24:12     INFO -      raise WinError()
15:24:12     INFO -  WindowsError: [Error 6] The handle is invalid.
15:24:12     INFO -  FAIL
15:24:12     INFO -  test_wait_after_process_finished (test_wait.MozrunnerWaitTestCase)
15:24:12     INFO -  Bug 965714: wait() after stop should not raise an error ... ProcessManager UNABLE to use job objects to manage child processes
15:24:12     INFO -  ProcessManager NOT managing child processes
15:24:12     INFO -  FAIL

<snip>

15:24:16     INFO -  ======================================================================
15:24:16     INFO -  ERROR: test_stop_interactive (test_interactive.MozrunnerInteractiveTestCase)
15:24:16     INFO -  Bug 965183: Explicitely stop process in interactive mode
15:24:16     INFO -  ----------------------------------------------------------------------
15:24:16     INFO -  Traceback (most recent call last):
15:24:16     INFO -    File "C:\slave\test\build\tests\mozbase\mozrunner\tests\mozrunnertest.py", line 27, in tearDown
15:24:16     INFO -      self.runner.cleanup()
15:24:16     INFO -    File "C:\slave\test\build\venv\lib\site-packages\mozrunner\base.py", line 184, in cleanup
15:24:16     INFO -      self.stop()
15:24:16     INFO -    File "C:\slave\test\build\venv\lib\site-packages\mozrunner\base.py", line 146, in stop
15:24:16     INFO -      self.process_handler.kill()
15:24:16     INFO -    File "c:\mozilla-build\python27\Lib\subprocess.py", line 1019, in terminate
15:24:16     INFO -      _subprocess.TerminateProcess(self._handle, 1)
15:24:16     INFO -  WindowsError: [Error 5] Access is denied
15:24:16     INFO -  ======================================================================
15:24:16     INFO -  FAIL: test_start_process_called_twice (test_start.MozrunnerStartTestCase)
15:24:16     INFO -  Start the process twice and test that first process is gone
15:24:16     INFO -  ----------------------------------------------------------------------
15:24:16     INFO -  Traceback (most recent call last):
15:24:16     INFO -    File "C:\slave\test\build\tests\mozbase\mozrunner\tests\test_start.py", line 31, in test_start_process_called_twice
15:24:16     INFO -      self.assertNotIn(process_handler.wait(1), [None, 0])
15:24:16     INFO -  AssertionError: None unexpectedly found in [None, 0]
15:24:16     INFO -  ======================================================================
15:24:16     INFO -  FAIL: test_start_with_outputTimeout (test_start.MozrunnerStartTestCase)
15:24:16     INFO -  Start the process and set a timeout
15:24:16     INFO -  ----------------------------------------------------------------------
15:24:16     INFO -  Traceback (most recent call last):
15:24:16     INFO -    File "C:\slave\test\build\tests\mozbase\mozrunner\tests\test_start.py", line 47, in test_start_with_outputTimeout
15:24:16     INFO -      self.assertFalse(self.runner.is_running())
15:24:16     INFO -  AssertionError: True is not false
15:24:16     INFO -  ======================================================================
15:24:16     INFO -  FAIL: test_start_with_timeout (test_start.MozrunnerStartTestCase)
15:24:16     INFO -  Start the process and set a timeout
15:24:16     INFO -  ----------------------------------------------------------------------
15:24:16     INFO -  Traceback (most recent call last):
15:24:16     INFO -    File "C:\slave\test\build\tests\mozbase\mozrunner\tests\test_start.py", line 40, in test_start_with_timeout
15:24:16     INFO -      self.assertFalse(self.runner.is_running())
15:24:16     INFO -  AssertionError: True is not false
15:24:16     INFO -  ======================================================================
15:24:16     INFO -  FAIL: test_stop_process (test_stop.MozrunnerStopTestCase)
15:24:16     INFO -  Stop the process and test properties
15:24:16     INFO -  ----------------------------------------------------------------------
15:24:16     INFO -  Traceback (most recent call last):
15:24:16     INFO -    File "C:\slave\test\build\tests\mozbase\mozrunner\tests\test_stop.py", line 19, in test_stop_process
15:24:16     INFO -      self.assertFalse(self.runner.is_running())
15:24:16     INFO -  AssertionError: True is not false
15:24:16     INFO -  ======================================================================
15:24:16     INFO -  FAIL: test_stop_process_custom_signal (test_stop.MozrunnerStopTestCase)
15:24:16     INFO -  Stop the process via a custom signal and test properties
15:24:16     INFO -  ----------------------------------------------------------------------
15:24:16     INFO -  Traceback (most recent call last):
15:24:16     INFO -    File "C:\slave\test\build\tests\mozbase\mozrunner\tests\test_stop.py", line 35, in test_stop_process_custom_signal
15:24:16     INFO -      self.assertFalse(self.runner.is_running())
15:24:16     INFO -  AssertionError: True is not false
15:24:16     INFO -  ======================================================================
15:24:16     INFO -  FAIL: test_process_post_stop_via_thread (test_threads.MozrunnerThreadsTestCase)
15:24:16     INFO -  Stop the runner and try it again with a thread a bit later
15:24:16     INFO -  ----------------------------------------------------------------------
15:24:16     INFO -  Traceback (most recent call last):
15:24:16     INFO -    File "C:\slave\test\build\tests\mozbase\mozrunner\tests\test_threads.py", line 69, in test_process_post_stop_via_thread
15:24:16     INFO -      self.assertNotIn(returncode, [None, 0])
15:24:16     INFO -  AssertionError: None unexpectedly found in [None, 0]
15:24:16     INFO -  ======================================================================
15:24:16     INFO -  FAIL: test_process_stop_via_multiple_threads (test_threads.MozrunnerThreadsTestCase)
15:24:16     INFO -  Stop the runner via multiple threads
15:24:16     INFO -  ----------------------------------------------------------------------
15:24:16     INFO -  Traceback (most recent call last):
15:24:16     INFO -    File "C:\slave\test\build\tests\mozbase\mozrunner\tests\test_threads.py", line 52, in test_process_stop_via_multiple_threads
15:24:16     INFO -      self.assertNotIn(returncode, [None, 0])
15:24:16     INFO -  AssertionError: None unexpectedly found in [None, 0]
15:24:16     INFO -  ======================================================================
15:24:16     INFO -  FAIL: test_wait_after_process_finished (test_wait.MozrunnerWaitTestCase)
15:24:16     INFO -  Bug 965714: wait() after stop should not raise an error
15:24:16     INFO -  ----------------------------------------------------------------------
15:24:16     INFO -  Traceback (most recent call last):
15:24:16     INFO -    File "C:\slave\test\build\tests\mozbase\mozrunner\tests\test_wait.py", line 32, in test_wait_after_process_finished
15:24:16     INFO -      self.assertNotIn(returncode, [None, 0])
15:24:16     INFO -  AssertionError: None unexpectedly found in [None, 0]
15:24:16     INFO -  ----------------------------------------------------------------------
15:24:16     INFO -  Ran 272 tests in 74.622s
15:24:16     INFO -  FAILED (failures=8, errors=1, skipped=5)
15:24:18    ERROR - Return code: 1

[1] https://hg.mozilla.org/projects/cedar/rev/6796d15eba33
Maybe we face one of the delayed shutdown issues here, e.g. bug 965309. There are a couple present as of now. So increasing the timeout for all of the tests might indeed help.
OS: Linux → Windows 8
Hardware: x86_64 → All
You need to log in before you can comment on or make changes to this bug.