1015255 - [Dialer] "Bamba" string displayed on Call Waiting button

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::L10n, defect)

Description

[Théo Chevalier]

Attachment: Screenshot from latest master on Flame

1. Call someone.
2. Someone call you

-> "Bamba" is displayed on the call waiting button.

I did a grep on gaia, can't find "Bamba". Weird bug :)

Comment 2

[bhavana bajaj [:bajaj]]

Ugly visual bug we cannot ship with :(, blocking.

Comment 3

[Eric Chang [:ericcc] [:echang]]

The attached screenshot in 1019202 is the new design, reproducible in Flame with build 20140605160202.
https://bug1019202.bugzilla.mozilla.org/attachment.cgi?id=8432754

### Build Information
Device: Flame
Gaia      908f94fda04462001ece86e6b6c15ad8b05f7526
Gecko     https://hg.mozilla.org/mozilla-central/rev/5e8e9d864a4d
BuildID   20140605160202
Version   32.0a1
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014

Comment 4

[Eric Chang [:ericcc] [:echang]]

Happened with master(en), not localized UI.

Comment 5

[Anthony Ricaud (:rik)]

We think it might be changing .innerHTML to .ariaLabel in the localisation files or something like that.

Comment 6

[Maria Angeles Oteo (:oteo)]

Just commenting that it seems a bug specific of Flame device. 
At least, I am not able to reproduce it with muy buri.

Comment 7

[Théo Chevalier]

Attachment: Screenshot from latest master (Buri)

Hm, I can reproduce on Buri, with latest master.

And the funny part is that is displays a totally different string

Comment 8

[Théo Chevalier]

(In reply to Anthony Ricaud (:rik) from comment #5)
> We think it might be changing .innerHTML to .ariaLabel in the localisation
> files or something like that.

just noticed that "Bamba" comes from Xhosa locale, here: http://mxr.mozilla.org/l10n-gaia/source/xh/apps/communications/dialer/dialer.properties#57

Comment 9

[Francesco Lodolo [:flod]]

en-US and updated locales don't have that string anymore on master, they have hold.ariaLabel

xh still have "hold" on master, like sk (second screenshot you posted, "Podržať")
https://hg.mozilla.org/gaia-l10n/sk/file/default/apps/communications/dialer/dialer.properties#l58

Not sure what's going on, if that's a build or run-time issue.

Comment 10

[Harvey]

B2G Inbound Regression Window

Last Working 
Environmental Variables:
Device: Buri
BuildID: 20140402123132
Gaia: 039037c16948c0985f6779886fac595b111979f4
Gecko: e7b7bdbffe2b
Version: 31.0a1
Firmware Version: v1.2-device.cfg

First Broken
Environmental Variables:
Device: Buri
BuildID: 20140402130133
Gaia: 208d70961b6e3f615b9195d9558157bf7b1fdd28
Gecko: ba30e8f5d6b4
Version: 31.0a1
Firmware Version: v1.2-device.cfg

Last Working Gaia First Broken Gecko: Issue does NOT reproduce
Gaia: 039037c16948c0985f6779886fac595b111979f4
Gecko: ba30e8f5d6b4

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: 208d70961b6e3f615b9195d9558157bf7b1fdd28
Gecko: e7b7bdbffe2b

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/039037c16948c0985f6779886fac595b111979f4...208d70961b6e3f615b9195d9558157bf7b1fdd28

Comment 11

[Johan Lorenzo [:jlorenzo]]

Broken by Bug 923139. Can you fix this regression?

Comment 12

[Yura Zenevich [:yzen] (please use "needinfo")]

Looks like this is not the issue of a l10n bundle having an older hold=Hold string instead of hold.ariaLabel=Hold . It looks like a string from a wrong locale is somehow being loaded into markup.

Comment 13

[Anthony Ricaud (:rik)]

Per comment 9 and 12, this is not a dialer bug but an L10n one.

We can still help by changing the name of the hold attribute in the dialer code base if you need it.

Comment 14

[Zibi Braniecki [:zbraniecki][:gandalf]]

Stas, can you verify if that's possible that it's the inconsistency between entity and entity.ariaLabel between locales?

Comment 15

[Staś Małolepszy :stas]

Sure, I'll have a look while you're on PTO, no worries.  Leaving the needinfo request for now.

Comment 16

[Zibi Braniecki [:zbraniecki][:gandalf]]

Kevin: for the future reference. Please, f? me or stas on bugs like that. We want to take part in designing the interaction between web components and l10n.

Comment 17

[Zibi Braniecki [:zbraniecki][:gandalf]]

wrong bug. sorry!

Comment 18

[Staś Małolepszy :stas]

Attachment: Patch

Pull request:  https://github.com/mozilla-b2g/gaia/pull/20441

Travis: https://travis-ci.org/mozilla-b2g/gaia/builds/27404904
Try: https://tbpl.mozilla.org/?tree=Gaia-Try&rev=9a38e482e33c

The root cause of this is that during buildtime we use the same document object for all locales that we optimize for.  If language A has an old entity defined ('hold'), and language B does not (because it's now called hold.ariaLabel), we don't erase the textContent of the element, and the translation from language A remains.

The fix is easy, however.  We actually don't need to pretranslate the HTML into anything else than the default language.  It's the only one that is saved into the zip anyways.

This patch keeps the getDictionary part of the build time optimization (concatenation into a single JSON file and inlining some strings in <script> tags in HTML), but only actually pretranslates the HTML into the default language.

Comment 19

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8439197 [details] [diff] [review]
Patch

Review of attachment 8439197 [details] [diff] [review]:
-----------------------------------------------------------------

Sweet. That will make blacklisting from pretranslation easier. r+

Comment 21

[Staś Małolepszy :stas]

Commit: https://github.com/mozilla-b2g/gaia/commit/67cf2a337afced0e822e9d32d3374e07aa6c0fd3
Master: https://github.com/mozilla-b2g/gaia/commit/4aaa14888e862e0980642a7c2db71865d3c773d8

L20n.js: https://github.com/l20n/l20n.js/commit/aebe9ee6e9136df0edf0ff688ece64ffd2505c87

Comment 22

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/649eb23de2949713dfb07a827c482b78bb9bfae3

Comment 23

[Loli (:lolimartinezcr)]

Tested and working
Hamachi
2.1
Gecko-a3c4c53
Gaia-5f9f64a

Hamachi
2.0
Gecko-3bfc06b
Gaia-5e14503

Comment 24

[Coler]

This issue has been verified successfully on Flame2.0&2.1.

Reproducing rate: 0/5
See attachment: Verify_Flame_Calling.mp4

Flame 2.0 build version:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141127000203
Version         32.0

Flame2.1 build version:
Gaia-Rev        5372b675e018b6aac97d95ff5db8d4bd16addb9b
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/f34377ae402b
Build-ID        20141127001201
Version         34.0

Comment 25

[Coler]

Attachment: Verify_Flame_Calling.MP4