1015264 - [Dialer] "TODAY" and "YESTERDAY" are reused from contacts.properties in Call log header

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Théo Chevalier]

In Call log, "Today" and "Yesterday" strings are picking translations from contacts.properties.

I guess the Dialer App is embedding the Contacts App, and since the strings entity have the same name, there is a conflict.
We'll need to rename those two strings:

http://hg.mozilla.org/gaia-l10n/en-US/file/default/apps/communications/dialer/dialer.properties#l66
http://hg.mozilla.org/gaia-l10n/en-US/file/default/apps/communications/dialer/dialer.properties#l72

And make sure there is no other conflict like that.


For the record, in French we added a comma in https://hg.mozilla.org/gaia-l10n/fr/file/d3e6e8581fba/apps/communications/contacts/contacts.properties#l187 and we don't want this string to be displayed in call log :)

Comment 1

[Gabriele Svelto [:gsvelto]]

Are those strings immediately visible in the call log (i.e. by opening the dialer then switching to the call log) or do they become visible only when switching to the contacts tab in the dialer? From what I can tell the dialer itself isn't importing the contacts properties. Also, is there a specific reason as to why you're embedding punctuation in those strings only in French? As we discovered while working on RTL commas are quite different in certain languages so if they are needed it's better to put them in a separate property and then build the whole string using references to the word(s) plus the comma.

Comment 2

[BMO Automation]

Firefox OS is not being worked on